🐛 Instantiate kube index informers by default #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcp-ci-bot
added
dco-signoff: yes
sttts
changed the title
sttts
force-pushed
the
sttts-kube-informer-by-default
branch
from
1ebacf2 to
6ef6466
Compare
kcp-ci-bot
added
size/M
Signed-off-by: Dr. Stefan Schimanski <[email protected]>
sttts
force-pushed
the
sttts-kube-informer-by-default
branch
4 times, most recently
from
0f0b2cc to
edf9683
Compare
kcp-ci-bot
added
size/L
…tion tests Signed-off-by: Dr. Stefan Schimanski <[email protected]>
sttts
force-pushed
the
sttts-kube-informer-by-default
branch
from
edf9683 to
e50f901
Compare
|
LGTM label has been added. Git tree hash: e707843ce631f6c881090c851f28522038f5f1a6
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: embik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our wrapper overrides the
NewInformermethod in order to create scopable cluster-aware shared index informers. But in normal, non-kcp mode we don't want that and instead instantiate a normal kube shared index informers, with traditionalnamespace/namekeys without cluster name.This matter when running a controller against one single workspace. Every object will have a
kcp.io/clusterannotation, but we don't want it as part of the informer key.