Memory leak - v8.x

[sschizas]

Hello,

I am using the following code to set up aggressive caching for the pipeline:

let dataLoaderConfiguration = DataLoader.defaultConfiguration
dataLoaderConfiguration.urlCache = nil
let dataLoader: DataLoader = .init(configuration: dataLoaderConfiguration, validate: DataLoader.validate)

var configuration = ImagePipeline.Configuration()
configuration.dataCache = try? DataCache(name: "com.theblueground.guestapp.DataCache")
configuration.dataLoader = dataLoader
configuration.imageCache = ImageCache()
ImagePipeline.shared = ImagePipeline(configuration: configuration)

I released there is a memory leak at DataLoader.init(configuration:validate:) method.

See the attached screenshots for more details.

[kean]

Hi, @sschizas. Thanks for the reporting. I noticed this leak too, I was not able to fix it yet. I haven't prioritized it yet since it doesn't affect memory usage – you typically only instantiate a session once per app launch.

[kean]

The issue was that DataLoader was not invalidating its session when deallocated. So when you were changing the data loader, the default one was not getting deallocated.

I fixed it by adding the following deinit method implementation in DataLoader:

deinit {
    session.invalidateAndCancel()
}

Seems like a straightforward fix. The documentation explicitly states that the session must be invalidated manually, otherwise it leaks memory.