Skip to content

Update/swift 5#217

Merged
kean merged 6 commits into
kean:masterfrom
DanielStormApps:update/Swift_5
Apr 1, 2019
Merged

Update/swift 5#217
kean merged 6 commits into
kean:masterfrom
DanielStormApps:update/Swift_5

Conversation

@DanielStormApps

Copy link
Copy Markdown

Summary

  • Update for Swift 5 and Xcode 10.2 support

Notes

Comment thread Sources/Internal.swift
Comment thread Sources/ImageRequest.swift
@kean

kean commented Mar 27, 2019

Copy link
Copy Markdown
Owner

Thanks you, @DanielStormApps! I reviewed your changes and made a couple of comments.

Also .travis.yml needs an update.

…sion check to `sha1` `String` extension. Update `.travis.yml`.
@DanielStormApps

Copy link
Copy Markdown
Author

Thanks you, @DanielStormApps! I reviewed your changes and made a couple of comments.

Also .travis.yml needs an update.

Updated. Not sure if I applied the changes you had intended. Seems the builds are failing except for 10.2 environments.

@kean

kean commented Mar 28, 2019

Copy link
Copy Markdown
Owner

Thank you for addressing the comments. I will review and merge this on the weekend. If there are any remaining issues, I'm will address them. Thanks again, @DanielStormApps!

@kean kean merged commit e18b4df into kean:master Apr 1, 2019
@kean

kean commented Apr 1, 2019

Copy link
Copy Markdown
Owner

@DanielStormApps merged this plus merged the changes to remove per-platform targets. So now instead of Nuke iOS, Nuke macOS, etc targets we have a single target. No duplication.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants