Update/swift 5#217
Merged
Merged
Conversation
…e of `withUnsafeBytes`.
….xcodeproj` `SWIFT_VERSION` to `5.0`. Replace `hashValue` with `hash(into:)` to satisfy `Hashable` protocol` conformance.
DanielStormApps
commented
Mar 27, 2019
kean
reviewed
Mar 27, 2019
Owner
|
Thanks you, @DanielStormApps! I reviewed your changes and made a couple of comments. Also |
…sion check to `sha1` `String` extension. Update `.travis.yml`.
Author
Updated. Not sure if I applied the changes you had intended. Seems the builds are failing except for 10.2 environments. |
Owner
|
Thank you for addressing the comments. I will review and merge this on the weekend. If there are any remaining issues, I'm will address them. Thanks again, @DanielStormApps! |
piercifani
approved these changes
Mar 28, 2019
Owner
|
@DanielStormApps merged this plus merged the changes to remove per-platform targets. So now instead of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Notes
Hashableupdates are outside my comfort zone. There may be a better way to satisfy the new requirements.hash(into:)is a replacement forhashValue: https://developer.apple.com/documentation/swift/hashable/2995575-hash