Add support for loading image into TVPosterView#602
Merged
kean merged 1 commit intoSep 17, 2022
Conversation
`TVPosterView` now supports loading image using Nuke out-of-the-box (`TVPosterView` now conforms to `Nuke_ImageDisplaying`)
Owner
|
Thanks for the contribution, @lukaskukacka. I appreciate that you even added a unit test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TVPosterViewnow supports loading image using Nuke out-of-the-box (TVPosterViewnow conforms toNuke_ImageDisplaying).TVPosterViewis a crucial UI component on tvOS.While it is easy to add this conformance in your project, imho it is nice to have it out of the box in the library.
In my specific case, having it directly in the library is actually the only way to make my whole project to compile.
Custom conformance in my project worked fine with Nuke v. 10, but since update to v. 11 (which moves these extensions to
NukeExtensions), using custom extension will no longer compile.I guess it is caused by how Swift access control works + specific setup of my project (private frameworks with multi-level hierarchy + Nuke hidden privately in one of private frameworks under custom wrapper interface).
Thanks a lot for considering my change.
And big thanks for your time and effort on this amazing library! 🙂