Preview Refactor #2553
Merged
ravi-kumar-pilla merged 40 commits intomainfrom Jan 21, 2026
Merged
Conversation
Signed-off-by: Ravi Kumar <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: Ravi Kumar <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: Ravi Kumar <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: Ravi Kumar <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: Ravi Kumar <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: Ravi Kumar <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: Ravi Kumar <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: Ravi Kumar <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: Ravi Kumar <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: Ravi Kumar <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: Ravi Kumar <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: Ravi Kumar <ravi_kumar_pilla@mckinsey.com>
…o-viz into feat/node_preview Signed-off-by: Ravi Kumar <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: Ravi Kumar <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: Ravi Kumar <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: Ravi Kumar <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: Ravi Kumar <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: Ravi Kumar <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: Ravi Kumar <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: Ravi Kumar <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: Ravi Kumar <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: Ravi Kumar <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: Ravi Kumar <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: Ravi Kumar <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: Ravi Kumar <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: Ravi Kumar <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: Ravi Kumar <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: Ravi Kumar <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: Ravi Kumar <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: Ravi Kumar <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: Ravi Kumar <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: Ravi Kumar <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: Ravi Kumar <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: Ravi Kumar <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: Ravi Kumar <ravi_kumar_pilla@mckinsey.com>
ravi-kumar-pilla
requested review from
jitu5 and
rashidakanchwala
as code owners
Contributor
rashidakanchwala
left a comment
rashidakanchwala
left a comment
There was a problem hiding this comment.
I just did a first pass; and it looks very neat. i will have a deeper look at the code tomm.
jitu5
approved these changes
Jan 20, 2026
Contributor
jitu5
left a comment
jitu5
left a comment
There was a problem hiding this comment.
Amazing. thanks @ravi-kumar-pilla
Signed-off-by: Ravi Kumar <ravi_kumar_pilla@mckinsey.com>
5 tasks
Signed-off-by: Ravi Kumar <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: Ravi Kumar <ravi_kumar_pilla@mckinsey.com>
Contributor
Author
|
Hi @jitu5 , For some reason the CI check - |
Contributor
|
Hi Ravi, it happened to me as well. Just rename ur PR title and it will work. |
rashidakanchwala
approved these changes
Jan 21, 2026
Contributor
rashidakanchwala
left a comment
rashidakanchwala
left a comment
There was a problem hiding this comment.
I am approving this; just a nit on using switch instead of ‘ifs’
Signed-off-by: Ravi Kumar <ravi_kumar_pilla@mckinsey.com>
Contributor
Author
Curious to know how did you find the solution :D ... still we need to find a fix unless it is the issue with the action itself |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related to kedro-org/kedro#5317
Development notes
preview-type-renderernaming patternpreview-wrapperandpreview-rendererfor maximum code reuse and maintainabilitysrc/utils/normalize-preview.jsto normalize DataNode preview types (PlotlyPreview, ImagePreview, TablePreview, JSONPreview, HTMLPreview) into consistent { kind, content } formatQA notes
Checklist
RELEASE.mdfile