Skip to content

Add an option to add KeePassXC to PATH during installation #12171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

A2va
Copy link

@A2va A2va commented Jun 9, 2025

This will make life easier for those running keepassxc-cli in the terminal.

Screenshots

image

Testing strategy

I tested my modification with the msi installer, but I was unable to build the exe installer. I haven't tested it myself, but the CMake documentation states that it should work.

CPACK_NSIS_MODIFY_PATH
Modify PATH toggle. If this is set to “ON”, then an extra page will appear in the installer that will allow the user to choose whether the program directory should be added to the system PATH variable

Type of change

  • ✅ New feature (change that adds functionality)

@droidmonkey
Copy link
Member

We dont use the NSIS installer method anymore

@A2va
Copy link
Author

A2va commented Jun 9, 2025

Ok, I removed CPACK_NSIS_MODIFY_PATH

@A2va
Copy link
Author

A2va commented Jun 9, 2025

Also, just to be clear, when I tested the installer, no Qt DLL was present in the C:\Program Files\KeePassXC folder. Is that expected in a development environment?

@droidmonkey
Copy link
Member

We use our release tool to ensure deployment is setup correctly. The cmake alone is janky, fixing that with qt6

@A2va
Copy link
Author

A2va commented Jul 10, 2025

Is there anything that prevent this PR from being merged ? Or are you waiting on fixing the cmakelists when introducing qt6 ?

@droidmonkey
Copy link
Member

It'll be done you are good to go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants