Skip to content

[WIP] Support nested folders on Bitwarden import #12202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented Jun 15, 2025

Thanks for assigning this issue to me. I'm starting to work on it and will keep this PR's description up to date as I form a plan and make progress.

Original issue description:

Summary

To create a nested folder, give a new folder a name that includes the "parent" folder following by a forward slash (/) delimiter, for example Socials/Forums. You can also rename existing folders in the same way to nest them under other existing folders.

https://bitwarden.com/help/folders/

Fixes #11491.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copy link

codecov bot commented Jun 15, 2025

Codecov Report

Attention: Patch coverage is 78.04878% with 9 lines in your changes missing coverage. Please review.

Project coverage is 63.91%. Comparing base (c4b4be4) to head (cd22010).
Report is 12 commits behind head on develop.

Files with missing lines Patch % Lines
src/format/BitwardenReader.cpp 78.05% 9 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12202      +/-   ##
===========================================
+ Coverage    63.89%   63.91%   +0.01%     
===========================================
  Files          369      369              
  Lines        38943    38979      +36     
===========================================
+ Hits         24882    24910      +28     
- Misses       14061    14069       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@droidmonkey
Copy link
Member

Try this plan again

Copy link
Contributor Author

Copilot AI commented Jun 19, 2025

Try this plan again

I've implemented nested folder support for Bitwarden imports. The solution parses folder names with forward slashes (like "Socials/Forums") and creates the proper hierarchy. For example, "Work/Projects/Client A" now creates a Work group containing a Projects group containing a Client A group. The implementation includes a new test case and maintains backward compatibility with simple folder names. Commit: 5d83fbb

@Copilot Copilot AI requested a review from droidmonkey June 19, 2025 14:08
Copilot finished work on behalf of droidmonkey June 19, 2025 14:08
@droidmonkey
Copy link
Member

Check your solution again now that you have new instructions and environment

Copy link
Contributor Author

Copilot AI commented Jun 19, 2025

Check your solution again now that you have new instructions and environment

I've reviewed my solution thoroughly with the new instructions and environment:

Build & Tests: Code builds successfully and all tests pass (including my new nested folder test)
Code Formatting: Applied cmake --build . --target format to ensure proper formatting
Internationalization: Ran ./release-tool i18n lupdate to update translation files
Implementation: Correctly parses nested folder paths like "Socials/Forums" and "Work/Projects/Client A", creating proper group hierarchies
Backward Compatibility: Simple folder names continue to work as before
Edge Cases: Handles empty paths, existing groups, and various nesting scenarios

The solution follows KeePassXC patterns and successfully implements the Bitwarden nested folder feature as specified in the issue. Commit: cd22010

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

  • 184.155.130.134.in-addr.arpa
    • Triggering command: /home/REDACTED/work/keepassxc/keepassxc/build/tests/testicondownloader (dns block)
  • de.login.keepassxc.org
    • Triggering command: /home/REDACTED/work/keepassxc/keepassxc/build/tests/testicondownloader (dns block)
  • keepassxc.co.uk
    • Triggering command: /home/REDACTED/work/keepassxc/keepassxc/build/tests/testicondownloader (dns block)
  • keepassxc.org
    • Triggering command: /home/REDACTED/work/keepassxc/keepassxc/build/tests/testicondownloader (dns block)
  • login.keepassxc.co.uk
    • Triggering command: /home/REDACTED/work/keepassxc/keepassxc/build/tests/testicondownloader (dns block)
  • login.keepassxc.org
    • Triggering command: /home/REDACTED/work/keepassxc/keepassxc/build/tests/testicondownloader (dns block)
  • test.com
    • Triggering command: /home/REDACTED/work/keepassxc/keepassxc/build/tests/testicondownloader (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot finished work on behalf of droidmonkey June 19, 2025 14:38
@phoerious phoerious added the pr: ai-assisted Pull request contains significant contributions by generative AI label Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: ai-assisted Pull request contains significant contributions by generative AI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support nested folders on Bitwarden import
3 participants