Allow read-only native message files #12236
Open
+23
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's possible[^1] for a native message file to be both correct and read-only. When current versions of `keepassxc` encounter this, it fails, because it can't write to the file. In this situation it should only fail if the read-only file's contents are different to those it's trying to write. [^1]: e.g. when using an immutable OS management system like NixOS or home-manager.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow read-only native message files when the on-disk JSON matches the JSON
keepassxcwants to write.I use home-manager to manage my system. I found that it's most reliable when I let home-manager manage
~/.mozilla/native-messaging-hosts/org.keepassxc.keepassxc_browser.json. Instead of writing the file directly, home-manager creates a symlink to a read-only file in the Nix store. Current versions ofkeepassxcreport an error when they encounter this, because they unconditionally write to that file. This change prevents that error when the read-only file matches whatkeepassxcwould have written (up to formatting differences).Testing strategy
Manual inspection; recompiled
keepassxcand checked that it does what I want.Type of change