Add Window menu for macOS and specify Help menu to AppKit #12357
+65
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds proper macOS menu integration by implementing native Window and Help menu support through AppKit. The changes enable standard macOS application behavior with a native Window menu containing system-provided items like Minimize, Zoom, and window management functions, while also integrating the Help menu with AppKit to provide Spotlight search functionality.
- Adds a new
configureWindowAndHelpMenusmethod to handle macOS-specific menu integration - Creates a native Window menu with standard macOS window management items
- Integrates the Help menu with AppKit for Spotlight search support
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/gui/osutils/macutils/MacUtils.h | Declares the new configureWindowAndHelpMenus method |
| src/gui/osutils/macutils/MacUtils.cpp | Implements the trampoline method to call AppKit implementation |
| src/gui/osutils/macutils/AppKitImpl.mm | Contains the core implementation for creating and configuring native menus |
| src/gui/osutils/macutils/AppKitImpl.h | Declares the Objective-C method for menu configuration |
| src/gui/osutils/macutils/AppKit.h | Adds the C++ interface method and required includes |
| src/gui/MainWindow.cpp | Calls the menu configuration during main window initialization |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds proper integration of the Window and Help menus on macOS to align with standard macOS application behavior.
A native Window menu is now added to the application menu on macOS with Minimize, Zoom, Window Tiling buttons, and Bring All to Front menus automatically inserted by AppKit.
The Help menu now integrates with AppKit installing a Spotlight search item automatically.
Fixes #7028
Screenshots
The new Window menu item with most items added automatically by AppKit:
A spotlight search item are automatically added by AppKit:
Type of change