Clear sensitive data from memory after async operations #1213
+38
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add secure memory clearing for sensitive data in AsyncWorker classes. This is a defense-in-depth measure following secure coding best practices. Changes: - Add secure_clear_string() using volatile pointer to prevent optimization - Add secure_clear_buffer() for char arrays - Update destructors for SaltAsyncWorker, EncryptAsyncWorker, and CompareAsyncWorker to clear sensitive data when workers complete This ensures passwords and other sensitive inputs don't remain in process memory longer than necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add secure memory clearing for sensitive data in AsyncWorker classes. This is a defense-in-depth measure following secure coding best practices.
Changes:
This ensures passwords and other sensitive inputs don't remain in process memory longer than necessary.