Skip to content

Bump Jest to 29.x and drop support for Node.js 12.x #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 28, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/validate.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest, windows-latest]
node: [12.22.0, 12, 14.17.0, 14, 16.10.0, 16, 18]
node: [14.17.0, 14, 16.10.0, 16, 18]
runs-on: ${{ matrix.os }}
steps:
- name: 🛑 Cancel Previous Runs
Expand Down
12 changes: 6 additions & 6 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -70,9 +70,9 @@
"@rollup/plugin-json": "^4.1.0",
"@rollup/plugin-node-resolve": "^13.3.0",
"@rollup/plugin-replace": "^4.0.0",
"@types/jest": "^27.5.2",
"@types/jest": "^29.4.0",
"arrify": "^2.0.1",
"babel-jest": "^28.1.3",
"babel-jest": "^29.4.1",
"babel-plugin-macros": "^3.1.0",
"babel-plugin-minify-dead-code-elimination": "^0.5.2",
"babel-plugin-module-resolver": "^4.1.0",
Expand All @@ -92,11 +92,11 @@
"glob": "^8.0.3",
"husky": "^4.3.8",
"is-ci": "^3.0.1",
"jest": "^28.1.3",
"jest-environment-jsdom": "^28.1.3",
"jest": "^29.4.1",
"jest-environment-jsdom": "^29.4.1",
"jest-serializer-path": "^0.1.15",
"jest-snapshot-serializer-raw": "^1.2.0",
"jest-watch-typeahead": "^1.1.0",
"jest-watch-typeahead": "^2.2.2",
"lint-staged": "^12.5.0",
"lodash.camelcase": "^4.3.0",
"lodash.has": "^4.5.2",
Expand All @@ -118,7 +118,7 @@
"slash": "^3.0.0"
},
"engines": {
"node": "^12.22.0 || ^14.17.0 || ^16.10.0 || >=17.0.0",
"node": "^14.17.0 || ^16.10.0 || >=17.0.0",
"npm": ">=6"
}
}
14 changes: 7 additions & 7 deletions src/__tests__/__snapshots__/index.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -4,27 +4,27 @@ exports[`format calls node with the script path and args including inspect-brk a

exports[`format calls node with the script path and args: format script 1`] = `node <PROJECT_ROOT>/src/scripts/test.js --no-watch`;

exports[`format does not log for other signals: format signal 1`] = `Array []`;
exports[`format does not log for other signals: format signal 1`] = `[]`;

exports[`format logs for SIGKILL signal: format signal 1`] = `
Array [
Array [
[
[
The script "lint" failed because the process exited too early. This probably means the system ran out of memory or someone called \`kill -9\` on the process.,
],
]
`;

exports[`format logs for SIGTERM signal: format signal 1`] = `
Array [
Array [
[
[
The script "build" failed because the process exited too early. Someone might have called \`kill\` or \`killall\`, or the system could be shutting down.,
],
]
`;

exports[`format logs help with no args: format snapshotLog 1`] = `
Array [
Array [
[
[

Usage: ../ [script] [--flags]

Expand Down
2 changes: 1 addition & 1 deletion src/__tests__/__snapshots__/utils.js.snap
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`getConcurrentlyArgs gives good args to pass to concurrently 1`] = `
Array [
[
--kill-others-on-fail,
--prefix,
[{name}],
Expand Down