Skip to content

Docs - Fixed Syntax Error in vectorized_map function example #21503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2025

Conversation

dhantule
Copy link
Contributor

@dhantule dhantule commented Jul 23, 2025

I have fixed the vectorized_map function example in core.py, which had some syntax errors.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @dhantule, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving the accuracy and usability of the Keras documentation by fixing syntax errors in the example code snippets for the vectorized_map function. The changes ensure that the provided examples are syntactically correct and reflect the intended usage, making them more helpful for developers.

Highlights

  • Documentation Syntax Fix: Corrected missing colons in the def vectorized_map(function, elements) function definition examples within the keras/src/ops/core.py documentation.
  • Example Code Logic Refinement: Updated the stack(outputs) call to np.stack(outputs) in one of the vectorized_map function examples, ensuring the example uses the correct NumPy stacking function.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

Thank you for fixing the syntax errors in the vectorized_map docstring. The changes are correct and improve the documentation. I've added one suggestion to further improve the conciseness and consistency of an example code snippet by using a list comprehension, which is more idiomatic Python.

Comment on lines 1078 to +1081
outputs = []
for e in elements:
outputs.append(function(e))
return stack(outputs)
return np.stack(outputs)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For improved conciseness and consistency with other examples in this file (like the map function's docstring), consider using a list comprehension. This is generally the preferred Pythonic way to build a list.

This would simplify the body of the example function to a single line.

Suggested change
outputs = []
for e in elements:
outputs.append(function(e))
return stack(outputs)
return np.stack(outputs)
return np.stack([function(e) for e in elements])

@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.88%. Comparing base (129e3d7) to head (4260aef).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21503      +/-   ##
==========================================
+ Coverage   78.00%   82.88%   +4.87%     
==========================================
  Files         565      565              
  Lines       55701    55701              
  Branches     8691     8691              
==========================================
+ Hits        43451    46165    +2714     
+ Misses      10212     7421    -2791     
- Partials     2038     2115      +77     
Flag Coverage Δ
keras 82.69% <ø> (+4.84%) ⬆️
keras-jax 63.46% <ø> (?)
keras-numpy 58.66% <ø> (-0.01%) ⬇️
keras-openvino 33.99% <ø> (ø)
keras-tensorflow 63.89% <ø> (ø)
keras-torch 63.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Jul 24, 2025
@fchollet fchollet merged commit 8bb4b25 into keras-team:master Jul 24, 2025
9 checks passed
@dhantule dhantule deleted the fix-vectorized-map-examples branch July 24, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kokoro:force-run ready to pull Ready to be merged into the codebase size:XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants