Skip to content

Conversation

@samthakur587
Copy link
Contributor

@samthakur587 samthakur587 commented Jul 28, 2025

details : this pr i have implemented the numpy deg2rad to support openvino backend

CC, @gbaned could you please review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @samthakur587, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements support for the numpy.deg2rad function within the OpenVINO backend. Previously, this function was not supported, and attempting to use it would raise a NotImplementedError. With this change, users can now convert degrees to radians using OpenVINO operations, enhancing the backend's compatibility with NumPy functionalities.

Highlights

  • Enable numpy.deg2rad support: The deg2rad function in keras/src/backend/openvino/numpy.py has been fully implemented to convert degree values to radians using OpenVINO operations, replacing the previous NotImplementedError.
  • Update test exclusions: The test_deg2rad entries have been removed from the excluded_concrete_tests.txt file, indicating that the deg2rad functionality is now expected to pass tests within the OpenVINO backend.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for numpy.deg2rad to the OpenVINO backend. The implementation is well-structured and handles different input data types correctly. I've suggested a minor improvement to use np.pi for better precision and consistency, instead of a hardcoded value.

Comment on lines 658 to 659
pi = 3.14159265358979323846
pi_over_180 = pi / 180.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better precision and to maintain consistency with other parts of the codebase (e.g., arctan2), it's recommended to use np.pi instead of a hardcoded value for pi. This also makes the code more concise.

Suggested change
pi = 3.14159265358979323846
pi_over_180 = pi / 180.0
pi_over_180 = np.pi / 180.0

@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.74%. Comparing base (5d50953) to head (240c6a3).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #21524   +/-   ##
=======================================
  Coverage   82.73%   82.74%           
=======================================
  Files         567      567           
  Lines       56464    56477   +13     
  Branches     8825     8828    +3     
=======================================
+ Hits        46718    46731   +13     
  Misses       7582     7582           
  Partials     2164     2164           
Flag Coverage Δ
keras 82.55% <100.00%> (+<0.01%) ⬆️
keras-jax 63.80% <0.00%> (-0.02%) ⬇️
keras-numpy 58.28% <0.00%> (-0.02%) ⬇️
keras-openvino 34.66% <100.00%> (+0.03%) ⬆️
keras-tensorflow 64.24% <0.00%> (-0.02%) ⬇️
keras-torch 63.85% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hertschuh
Copy link
Collaborator

@samthakur587 , can you rebase to merge changes to excluded_concrete_tests.txt? Then I can merge. Thanks!

@samthakur587
Copy link
Contributor Author

@hertschuh done!

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Aug 8, 2025
@fchollet fchollet merged commit ea62750 into keras-team:master Aug 8, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kokoro:force-run ready to pull Ready to be merged into the codebase size:S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants