-
Notifications
You must be signed in to change notification settings - Fork 19.6k
[OpenVINO backend] Support numpy.deg2rad #21524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @samthakur587, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request implements support for the numpy.deg2rad function within the OpenVINO backend. Previously, this function was not supported, and attempting to use it would raise a NotImplementedError. With this change, users can now convert degrees to radians using OpenVINO operations, enhancing the backend's compatibility with NumPy functionalities.
Highlights
- Enable
numpy.deg2radsupport: Thedeg2radfunction inkeras/src/backend/openvino/numpy.pyhas been fully implemented to convert degree values to radians using OpenVINO operations, replacing the previousNotImplementedError. - Update test exclusions: The
test_deg2radentries have been removed from theexcluded_concrete_tests.txtfile, indicating that thedeg2radfunctionality is now expected to pass tests within the OpenVINO backend.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for numpy.deg2rad to the OpenVINO backend. The implementation is well-structured and handles different input data types correctly. I've suggested a minor improvement to use np.pi for better precision and consistency, instead of a hardcoded value.
keras/src/backend/openvino/numpy.py
Outdated
| pi = 3.14159265358979323846 | ||
| pi_over_180 = pi / 180.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better precision and to maintain consistency with other parts of the codebase (e.g., arctan2), it's recommended to use np.pi instead of a hardcoded value for pi. This also makes the code more concise.
| pi = 3.14159265358979323846 | |
| pi_over_180 = pi / 180.0 | |
| pi_over_180 = np.pi / 180.0 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21524 +/- ##
=======================================
Coverage 82.73% 82.74%
=======================================
Files 567 567
Lines 56464 56477 +13
Branches 8825 8828 +3
=======================================
+ Hits 46718 46731 +13
Misses 7582 7582
Partials 2164 2164
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@samthakur587 , can you rebase to merge changes to |
|
@hertschuh done! |
details : this pr i have implemented the numpy deg2rad to support openvino backend
CC, @gbaned could you please review