Skip to content

Conversation

@ILCSFNO
Copy link
Contributor

@ILCSFNO ILCSFNO commented Aug 8, 2025

Fixes #21562

@google-cla
Copy link

google-cla bot commented Aug 8, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @ILCSFNO, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

I've updated the documentation for the "alpha" parameter within the "mobilenet_v3" application in Keras. This change clarifies the acceptable "alpha" values when using the default 'imagenet' weights, addressing issue #21562.

Highlights

  • Documentation Update: Clarified the valid "alpha" values for the "mobilenet_v3" model when using default "imagenet" weights, specifying "0.75" and "1.0" for non-minimalistic models and "1.0" for minimalistic models.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the docstring for the alpha parameter in MobileNetV3 to clarify its valid values when using pretrained ImageNet weights. My review focuses on improving the clarity and formatting of this new documentation to make it more readable.

@codecov-commenter
Copy link

codecov-commenter commented Aug 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.14%. Comparing base (4e1b250) to head (d2254f0).

❗ There is a different number of reports uploaded between BASE (4e1b250) and HEAD (d2254f0). Click for more details.

HEAD has 6 uploads less than BASE
Flag BASE (4e1b250) HEAD (d2254f0)
keras 5 2
keras-torch 1 0
keras-tensorflow 1 0
keras-jax 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #21563       +/-   ##
===========================================
- Coverage   82.73%   62.14%   -20.60%     
===========================================
  Files         567      567               
  Lines       56464    56464               
  Branches     8825     8825               
===========================================
- Hits        46718    35087    -11631     
- Misses       7582    19200    +11618     
- Partials     2164     2177       +13     
Flag Coverage Δ
keras 62.13% <ø> (-20.42%) ⬇️
keras-jax ?
keras-numpy 58.41% <ø> (+0.11%) ⬆️
keras-openvino 34.76% <ø> (+0.12%) ⬆️
keras-tensorflow ?
keras-torch ?
keras.applications 22.81% <ø> (?)
keras.applications-numpy 22.81% <ø> (?)
keras.applications-openvino 22.81% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

ILCSFNO and others added 3 commits August 8, 2025 18:16
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@ILCSFNO
Copy link
Contributor Author

ILCSFNO commented Aug 8, 2025

Only fix the doc, not known why the performance is changed, could anyone point it out? Thanks a lot!

Copy link
Collaborator

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Aug 8, 2025
@fchollet fchollet merged commit 1d647c3 into keras-team:master Aug 8, 2025
5 of 8 checks passed
@ILCSFNO
Copy link
Contributor Author

ILCSFNO commented Aug 9, 2025

Thanks a lot!

@ILCSFNO ILCSFNO deleted the patch-1 branch August 9, 2025 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kokoro:force-run ready to pull Ready to be merged into the codebase size:XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix the Doc of alpha in mobilenet_v3

4 participants