Skip to content

Conversation

@miguelteixeiragomes
Copy link
Contributor

Pull request to fix issue #21648

@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.55%. Comparing base (08b5252) to head (7971d78).
⚠️ Report is 8 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #21650   +/-   ##
=======================================
  Coverage   82.55%   82.55%           
=======================================
  Files         571      571           
  Lines       57618    57646   +28     
  Branches     8999     9008    +9     
=======================================
+ Hits        47564    47589   +25     
- Misses       7759     7760    +1     
- Partials     2295     2297    +2     
Flag Coverage Δ
keras 82.35% <100.00%> (+<0.01%) ⬆️
keras-jax 63.49% <100.00%> (-0.03%) ⬇️
keras-numpy 57.84% <100.00%> (-0.03%) ⬇️
keras-openvino 34.42% <100.00%> (+0.03%) ⬆️
keras-tensorflow 64.20% <100.00%> (-0.03%) ⬇️
keras-torch 63.71% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@miguelteixeiragomes miguelteixeiragomes marked this pull request as ready for review September 9, 2025 19:18
Copy link
Collaborator

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Please add a unit test for the fix.

Added unit test that does not pass without the change in operation_utils.py
Fixing the test, used the wrong axes
@miguelteixeiragomes
Copy link
Contributor Author

miguelteixeiragomes commented Sep 11, 2025

@fchollet , sure, added a test with multiple negative axes, but without keepdims. Let me know if you think more tests are needed.
There is a test failing related to quantization, but I don't understand if there's any relation to the test I added.
Never mind this part, after a re-run if passed.
Thank you!

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Sep 15, 2025
@fchollet fchollet merged commit 779fd0b into keras-team:master Sep 15, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kokoro:force-run ready to pull Ready to be merged into the codebase size:XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants