Fix: keras.ops.quantile works with tf graph execution

[SamKnightGit]

A deque failing to be converted to a tensor in the transpose call in keras.ops.quantile caused errors when running in tf graph contexts. By constructing a list from the deque before passing it to the transpose call we avoid this error. Test added to cover this specific case.

Fixes #21781

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[gemini-code-assist]

Summary of Changes

Hello @SamKnightGit, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug in keras.ops.quantile that prevented its proper execution within TensorFlow's graph mode. The core problem stemmed from tf.transpose's inability to process a collections.deque object directly when used as the permutation argument. The solution involves a small but crucial change: converting the deque to a standard Python list before the transpose operation. This ensures compatibility with TensorFlow's graph execution, making keras.ops.quantile more robust. A dedicated test case has also been added to validate this fix specifically for TensorFlow graph contexts.

Highlights

• Bug Fix: Resolved an issue where keras.ops.quantile failed during TensorFlow graph execution due to tf.transpose not handling deque objects correctly.
• Implementation: The fix involves explicitly converting the collections.deque object to a list before passing it as the perm argument to tf.transpose.
• Test Coverage: A new test case, test_quantile_in_tf_function, has been added to ensure the corrected quantile operation works as expected within a tf.function context.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses a bug where keras.ops.quantile would fail during TensorFlow graph execution. The issue stemmed from tf.transpose being unable to handle a collections.deque object for its permutation argument within a graph context. The fix correctly converts the deque to a list before the transpose call, resolving the error. A new test case, test_quantile_in_tf_function, has been added to specifically verify this fix by running quantile inside a @tf.function-decorated function, ensuring the operation now works as expected in graph mode. The changes are accurate and the test is well-targeted. This is a good contribution.

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.63%. Comparing base (c2bc6cf) to head (96e7230).

Additional details and impacted files

@@           Coverage Diff           @@
##           master   #21782   +/-   ##
=======================================
  Coverage   82.63%   82.63%           
=======================================
  Files         577      577           
  Lines       59316    59316           
  Branches     9300     9300           
=======================================
  Hits        49018    49018           
  Misses       7910     7910           
  Partials     2388     2388           

Flag	Coverage Δ
keras	82.46% <100.00%> (ø)
keras-jax	63.32% <0.00%> (ø)
keras-numpy	57.56% <0.00%> (+<0.01%)	⬆️
keras-openvino	34.29% <0.00%> (ø)
keras-tensorflow	64.11% <100.00%> (ø)
keras-torch	63.62% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[fchollet]

Thanks for the fix!