Skip to content

Reduce unit testing frequency #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kernelmethod
Copy link
Owner

@kernelmethod kernelmethod commented Aug 31, 2021

This PR changes the GitHub Actions configuration so that we're only running unit tests on Ubuntu for the latest (non-nightly) version of Julia, and only on (a) pushes to master or (b) pull requests. This should make the CI pipeline less error-prone, but should also guarantee we don't run afoul of GitHub Actions' usage limits.

This PR also fixes some of the doctests that were broken by Julia 1.6.

@kernelmethod kernelmethod self-assigned this Aug 31, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2021

Codecov Report

Merging #36 (dc50b96) into master (a76d5e0) will decrease coverage by 1.26%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #36      +/-   ##
==========================================
- Coverage   91.81%   90.54%   -1.27%     
==========================================
  Files          11       10       -1     
  Lines         403      402       -1     
==========================================
- Hits          370      364       -6     
- Misses         33       38       +5     
Impacted Files Coverage Δ
src/function_hashing/monte_carlo.jl 90.90% <ø> (ø)
src/LSHBase.jl 48.38% <0.00%> (-12.91%) ⬇️
src/hashes/lshfunction.jl 88.88% <0.00%> (-11.12%) ⬇️
src/LSHFunctions.jl

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a76d5e0...dc50b96. Read the comment docs.

- Stop running unit tests on pushes to every branch; only run them on
  (a) pushes to master or (b) pull requests.
- Stop running unit tests on nightly (since they don't provide much
  useful information and fail too often).
- Only run unit tests on Linux so that we don't go outside of GitHub
  Action's usage limits.
@kernelmethod kernelmethod force-pushed the kernelmethod/ci_updates branch from a15078d to 4383abd Compare August 31, 2021 15:39
@kernelmethod kernelmethod changed the title Update CI to stop running unit tests on pushes to every branch. Reduce unit testing frequency Aug 31, 2021
Fix the doctests to handle a change between Julia 1.5 and 1.6 where
one-dimensional arrays like Array{1} and BitArray{1} are displayed in
the REPL output as "Vector" and "BitVector".
@kernelmethod kernelmethod force-pushed the kernelmethod/ci_updates branch from a89437c to dc50b96 Compare August 31, 2021 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants