fix(java-sdk): fix followDependenciesExecution return type

[ClemDoum]

What changes are being made and why?

---

The /api/v1/{tenant}/executions/{executionId}/follow-dependencies API routes returns a stream of ExecutionStatusEvent yet the client code deserialize the event stream as a stream of Execution which ends up in a stream of empty objects when calling KestraClient().builder().executions().followDependenciesExecution(executionId, MAIN_TENANT, false, true) (because property names don't match)

How the changes have been QAed?

---

Before:

KestraClient().builder().executions().followDependenciesExecution(executionId, MAIN_TENANT, false, true).toStream().toList()

return a list of empty Execution objects (null properties every everywhere

After:

KestraClient().builder().executions().followDependenciesExecution(executionId, MAIN_TENANT, false, true).toStream().toList()

should return a list of valid ExecutionStatusEvent (I wasn't able to test properly as I wasn't able to setup unit test properly)

[Skraye]

Hello, I think we will need an issue and a reproducer because I dont think your changes are correct.
Below, the ExecutionStatusEvent that you did use :

as you can see, only the executionId is populated, everything else is null

On the other side, with the current Execution, every properties that should be filled are correctly populated.

If you want to do further test on your side, you can use the beginning of the run-tests.sh script to publish a local version of the lib locally and use it on your own project.

Side note for information: Our SDK is auto-generated, so please avoid modifying source files as changes will be overwritten. Specifically, methods using SSE are overridden during generation (see reference here), but we can handle that specific modification internally.

Thanks for the contribution!

[ClemDoum]

Hi @Skraye, I might be using a different setup than your.
I'm running kestra open source v1.1.4 standalone server.

Then I slightly modified the ExecutionsApiTest.followDependenciesExecution like this (for the purpose of reproducing):

@Test
    public void followDependenciesExecution() throws Exception {
        Execution execution = createdExecution(LOG_FLOW, StateType.SUCCESS);
        String executionId = execution.getId();

        CountDownLatch completionLatch = new CountDownLatch(1);

        kestraClient().executions().followDependenciesExecution(executionId, MAIN_TENANT, false, true)
            .toStream()
            .forEach(e -> assertNotNull(e.getId()));

        kestraClient().executions().followDependenciesExecution(executionId, MAIN_TENANT, false, true)
                .doOnNext(event -> {
                    assertThat(event.getFlowId()).isEqualTo(execution.getFlowId());
                })
                .doFinally(signalType -> {
                    completionLatch.countDown();
                })
                .subscribe();

        boolean completed = completionLatch.await(30, TimeUnit.SECONDS);

        assertThat(completed).isTrue();
    }

I do get the following assertion error:

expected: not <null>
org.opentest4j.AssertionFailedError: expected: not <null>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:152)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertNotNull.failNull(AssertNotNull.java:49)
	at org.junit.jupiter.api.AssertNotNull.assertNotNull(AssertNotNull.java:35)
	at org.junit.jupiter.api.AssertNotNull.assertNotNull(AssertNotNull.java:30)
	at org.junit.jupiter.api.Assertions.assertNotNull(Assertions.java:301)
	at io.kestra.example.ExecutionsApiTest.lambda$followDependenciesExecution$47(ExecutionsApiTest.java:1056)
	at java.base/java.util.Iterator.forEachRemaining(Iterator.java:133)

What I don't understand is that the base test doest work event without my addition. If i switch the return type to ExecutionStatusEvent then everything works as expected.

Thank your for pointing out the overwriting issue with the template !

[Skraye]

Checked again, see my error, and you are right!
I'm merging your pull request and will do the adjustement on another commit, thank a lot for your contribution!

[Skraye]

LGTM

[Skraye]

@ClemDoum can you rebase your branch so I can merge it ? I dont have permission to commit on your branch

[ClemDoum]

rebase done @Skraye