Make DbtCLI task fail if any of the listed `commands` returns a non-zero error code

[anna-geller]

Feature description

Atm, it seems that the last command is what determines success or failure. We should change that to fail the task if any command fails.

[aballiet]

I am willing to provide a PR for this one 👍

[loicmathieu]

This is easily reproducible with such flow:

id: multi-failed-commands
namespace: myteam

tasks:
  - id: shell
    type: io.kestra.plugin.scripts.shell.Commands
    runner: PROCESS
    commands:
      - notfound
      - sleep 1

If you launch it, it ends in warning, if you remove the last command it ends in ERROR.

@aballiet are you still willing to have a look or should I take it over? The issue is not on the DBT plugin but on our script infrastructure in the plugin-script library.

[aballiet]

You can take it @loicmathieu ,will not have time for it 😅

[fhussonnois]

@loicmathieu @aballiet I don't think the current behavior is a bug because it's actually how the /bin/bash interpreter works.

Using the Loic'example, we can get the expected behavior like this:

id: multi-failed-commands
namespace: myteam

tasks:
  - id: shell
    type: io.kestra.plugin.scripts.shell.Commands
    runner: PROCESS
    commands:
      - set -e #Enables the immediate exit mode in case of an error.
      - notfound
      - sleep 1  # will never be executed

Currently, all the commands are executed in a single process so its logical that the exit_code corresponds to the final executed command.

[loicmathieu]

That's a good point, it works the same if using a Script and not a command, set -e should be added.
I'll close it then.