fix(pod): respect ContainersReady status in waitForPodReady

[FourFriends]

Summary

This PR updates PodService.waitForPodReady to make the readiness check more strict.

Details

Previously, the method only checked for the presence of a ContainersReady condition or a PodCompleted reason, without verifying the condition status. As a result, Pods with ContainersReady status False or Unknown could be treated as ready.

Now, waitForPodReady only considers a Pod as ready when:

• it has a ContainersReady condition with status True, or
• it has a condition with reason PodCompleted.

This makes the Pod readiness handling more accurate and aligned with Kubernetes semantics.

resolve this issue #244

[FourFriends]

@fdelbrayelle can you help review this pr, thanks?

[fdelbrayelle]

Thank you for your contribution @FourFriends! Could you write a unit test who check this new business rule please 🙏 ? Thanks!

[FourFriends]

@fdelbrayelle Hi

I've added unit tests for waitForPodReady to verify the new business rule that ContainersReady status must be "True". The tests cover:

• ContainersReady=True returns ready ✅
• ContainersReady=False/Unknown/empty does not return ready ✅
• PodCompleted and Failed phase still work (preserved behavior) ✅

Tests use Mockito and don't require a real K8s cluster. Thanks! 🙏

[fdelbrayelle]

Hi @FourFriends 👋
Thank you. We'd prefer you to add real tests without mocks in this test class. You can test it even locally by running .github/setup-unit.sh which runs a K8s cluster thanks to Kind for you.

[Malaydewangan09]

Hey @FourFriends 👋, are there any updates on this?

[FourFriends]

@Malaydewangan09 I've been quite busy lately, but I will add the integration tests soon. thanks

[MilosPaunovic]

Hey @FourFriends, are there any updates on this?

[Malaydewangan09]

Closing in favour of #266

[FourFriends]

thanks, too busy last month, thanks again.