fix(test): preserve sidecars and fix pod deletion timeout in tests#274
Merged
fdelbrayelle merged 2 commits intomainfrom Mar 30, 2026
Merged
fix(test): preserve sidecars and fix pod deletion timeout in tests#274fdelbrayelle merged 2 commits intomainfrom
fdelbrayelle merged 2 commits intomainfrom
Conversation
Mirror of kestra-io/plugin-ee-kubernetes#104: the sidecar used `sleep 300` which kept the pod alive and caused the deletion wait to time out in CI. Replaced with `echo sidecar-done` so the sidecar exits immediately after the assertions are done.
…ision Port of kestra-io/plugin-ee-kubernetes#104: - AbstractPod: fix env var merging in containerDefaultSpec — container-specific values now correctly win over defaults on name collision (previously defaults were prepended, which could cause duplicate env var names) - AbstractPod: extract mergeEnvVars() helper used in both mergeContainerDefaults and applySidecarDefaultSpec - PodCreate: add removeReservedContainers() to strip any user-provided containers named init-files/out-files before Kestra injects its own file-transfer containers - PodCreate: improve spec description to document sidecar preservation behaviour
Contributor
📦 Artifacts
🧪 Java Unit Tests
🛡 TrivyVulnerability in:
|
| Vulnerability | Severity | Package | Installed Version | Fixed Version |
|---|---|---|---|---|
| GHSA-72hv-8253-57qq | HIGH | com.fasterxml.jackson.core:jackson-core | 2.20.1 | 2.18.6, 2.21.1, 3.1.0 |
| CVE-2025-67735 | MEDIUM | io.netty:netty-codec-http | 4.2.5.Final | 4.2.8.Final, 4.1.129.Final |
🔁 Unreleased Commits
3 commits since v1.6.3
| SHA | Title | Author | Date |
|---|---|---|---|
4740a8b |
chore(deps): bump io.kestra.gradle.inject-bom-versions (#272) | dependabot[bot] | Mar 30, 26, 6:44:37 AM UTC |
f9b65fe |
chore(deps): bump com.gradleup.shadow from 9.4.0 to 9.4.1 (#270) | dependabot[bot] | Mar 30, 26, 6:44:44 AM UTC |
8ff01d3 |
chore(deps): bump io.kestra.gradle.spotless-conventions (#271) | dependabot[bot] | Mar 30, 26, 6:45:41 AM UTC |
Malaydewangan09
approved these changes
Mar 30, 2026
This was referenced Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Port of kestra-io/plugin-ee-kubernetes#104 to this repository.
podSpecSidecarsPreservedtest: verifies that user-defined sidecar containers (not using reserved names) are preserved alongside Kestra's file-transfer containers whenoutputFilesis configured.containerDefaultSpecEnvMergingtest: verifies that env vars fromcontainerDefaultSpecare correctly merged with container-specific vars (container wins on collision).sleep 300toecho sidecar-doneso the pod can be deleted promptly after assertions, avoiding CI timeout.Test plan
podSpecSidecarsPreservedpassescontainerDefaultSpecEnvMergingpasses