Support glob-filtered allapers inputdirs for Stages 4-6#849
Merged
Conversation
Allow allapers=True runs to use glob-style inputdir values to narrow previous-stage aperture/background folders before the usual allapers loop runs. The glob is expanded relative to topdir through existing inputdir handling, and matched folders are mapped back to ap/bg pairs so Stages 4, 5, and 6 process only the requested combinations. Add logging for expanded allapers glob searches and a clear error when no candidate folders match. Preserve existing behavior for normal inputdir values and for glob-like inputdir values when allapers is False. Document nested Eureka output examples such as Stage3/S3_*_run*/ap5_bg*, and add focused tests for normal allapers behavior, glob filtering, multiple background matches, no-match errors, and allapers=False behavior.
github-project-automation
Bot
moved this to In progress
in Stage 5: Light Curve Fitting
github-project-automation
Bot
moved this to In progress
in Stage 4: Generate Lightcurves
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #849 +/- ##
==========================================
+ Coverage 59.79% 59.95% +0.16%
==========================================
Files 107 107
Lines 14074 14161 +87
==========================================
+ Hits 8415 8490 +75
- Misses 5659 5671 +12 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
kevin218
requested changes
Jun 5, 2026
github-project-automation
Bot
moved this from In progress
to Review in progress
in Road to v2.0
github-project-automation
Bot
moved this from In progress
to Review in progress
in Stage 4: Generate Lightcurves
github-project-automation
Bot
moved this from In progress
to Pending Review
in Stage 5: Light Curve Fitting
kevin218
approved these changes
Jun 10, 2026
github-project-automation
Bot
moved this from Review in progress
to Done
in Stage 4: Generate Lightcurves
github-project-automation
Bot
moved this from In progress
to Done
in Stage 6: Spectra Plotting
github-project-automation
Bot
moved this from Review in progress
to Done
in Road to v2.0
github-project-automation
Bot
moved this from Pending Review
to Done
in Stage 5: Light Curve Fitting
taylorbell57
added a commit
that referenced
this pull request
Jun 22, 2026
* Support glob-filtered allapers inputdirs for Stages 4-6 Allow allapers=True runs to use glob-style inputdir values to narrow previous-stage aperture/background folders before the usual allapers loop runs. The glob is expanded relative to topdir through existing inputdir handling, and matched folders are mapped back to ap/bg pairs so Stages 4, 5, and 6 process only the requested combinations. Add logging for expanded allapers glob searches and a clear error when no candidate folders match. Preserve existing behavior for normal inputdir values and for glob-like inputdir values when allapers is False. Document nested Eureka output examples such as Stage3/S3_*_run*/ap5_bg*, and add focused tests for normal allapers behavior, glob filtering, multiple background matches, no-match errors, and allapers=False behavior. * Document and test allapers glob ap/bg folder matching
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow allapers=True runs to use glob-style inputdir values to narrow previous-stage aperture/background folders before the usual allapers loop runs. The glob is expanded relative to topdir through existing inputdir handling, and matched folders are mapped back to ap/bg pairs so Stages 4, 5, and 6 process only the requested combinations.
Add logging for expanded allapers glob searches and a clear error when no candidate folders match. Preserve existing behavior for normal inputdir values and for glob-like inputdir values when allapers is False.
Document nested Eureka output examples such as
Stage3/S3_*_run*/ap5_bg*, and add focused tests for normal allapers behavior, glob filtering, multiple background matches, no-match errors, and allapers=False behavior.