Skip to content

Immediately reflect precision changes #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

DesertSnow
Copy link
Contributor

@DesertSnow DesertSnow commented Nov 16, 2017

2 issues when changing the precision of a numeric input:

  • the actual input field was only updated after regaining focus
  • the actual value was not updated, even when regaining focus

An example would be a numeric input with precision '2' and value '1,25'. When changing the precision to '1', the actual value should become '1.3'.

To provided code changes would result in:

  • the input field being updated immediatly
  • the actual value being updated

@maintainer: I know I should have entered an issue first. However, the change was small and I am allowed to keep working on my current project without having to wait for a new release. If you need any different action from me, please notify.
Issue: #45

@codecov
Copy link

codecov bot commented Nov 16, 2017

Codecov Report

Merging #44 into master will increase coverage by 0.11%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #44      +/-   ##
==========================================
+ Coverage    97.5%   97.61%   +0.11%     
==========================================
  Files           1        1              
  Lines          40       42       +2     
  Branches       14       14              
==========================================
+ Hits           39       41       +2     
  Partials        1        1
Impacted Files Coverage Δ
src/vue-numeric.vue 97.61% <100%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8bd4b0...5c4a562. Read the comment docs.

@kevinongko kevinongko merged commit 723a3f2 into kevinongko:master Nov 17, 2017
@kevinongko
Copy link
Owner

Thanks for the PR 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants