added a dark theme#21
Merged
Merged
Conversation
This is the first step for supporting dark theme
Contributor
Author
|
So this is only a suggestion on how to add a dark theme. And the colors is not perfect. |
kewisch
requested changes
Nov 3, 2020
Owner
kewisch
left a comment
kewisch
left a comment
There was a problem hiding this comment.
Can't believe its been almost a year. This looks almost ready, a few minor comments:
|
|
||
| this.selected = item; | ||
| this.shadowRoot.querySelector(".folder-list-body").focus(); | ||
| //this.shadowRoot.querySelector(".folder-list-body").focus(); |
Owner
There was a problem hiding this comment.
Curious why you removed this? I think this was needed to make it possible to navigate with the keyboard.
Contributor
Author
There was a problem hiding this comment.
As you see I put this in another PR. But I guess when I prepared this PR I already this comment in. If you want I can edit this PR.
Owner
There was a problem hiding this comment.
Yes, would appreciate if you could remove any commented out code from this PR. We can try to find a solution in your other PR for the focus issue.
kewisch
approved these changes
Aug 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first step for supporting dark theme