feat(keycloak_saml_client_installation_provider): support zip files #1239
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the documentation makes use of
saml-idp-descriptor
provider to fetch the saml xml.This provider seems not existent in the current version of keycloak.
I found a valid xml with the
mod-auth-mellon
provider but the returned value is a zip file.This zip file is currently being put in
value
attribute as string, as this is binary data, it breaks the file and we cannot use it in terraform. An easy fix would be to add avalue_base64
attribute but it would still remain hard to use as terraform does not provide a way to interact with a zip. We also could create a terraform function to help handle this zip file but it requires the terraform framework rather than the old SDK.I added a new
zip_files
map attribute that will contain all files contained in the zip.