Duplicate TCPRoute CRDs in envtest suite

[timflannagan]

The envtest suite is complaining about duplicate TCPRoute CRDs being applied. See the following log output for more information:

go test -race -v -count=1 -failfast ./internal/kgateway/setup/ -run TestScenarios/^lambda                                                                                                                                                       
=== RUN   TestScenarios
    ggv2setup_test.go:59: out: /home/timflannagan/.local/share/kubebuilder-envtest/k8s/1.23.5-linux-amd64
    ggv2setup_test.go:74: 2025-03-03T11:59:56.878-0500	DEBUG	controller-runtime.test-env	envtest/server.go:248	starting control plane
        
    ggv2setup_test.go:74: 2025-03-03T12:00:14.203-0500	DEBUG	controller-runtime.test-env	envtest/server.go:285	installing CRDs
        
    ggv2setup_test.go:74: 2025-03-03T12:00:14.203-0500	DEBUG	controller-runtime.test-env	envtest/crd.go:316	reading CRDs from path	{"path": "../../../install/helm/kgateway/crds"}
        
    ggv2setup_test.go:74: 2025-03-03T12:00:14.222-0500	DEBUG	controller-runtime.test-env	envtest/crd.go:434	read CRDs from file	{"file": "gateway.kgateway.dev_backends.yaml"}
        
    ggv2setup_test.go:74: 2025-03-03T12:00:14.224-0500	DEBUG	controller-runtime.test-env	envtest/crd.go:434	read CRDs from file	{"file": "gateway.kgateway.dev_directresponses.yaml"}
        
    ggv2setup_test.go:74: 2025-03-03T12:00:14.286-0500	DEBUG	controller-runtime.test-env	envtest/crd.go:434	read CRDs from file	{"file": "gateway.kgateway.dev_gatewayparameters.yaml"}
        
    ggv2setup_test.go:74: 2025-03-03T12:00:14.303-0500	DEBUG	controller-runtime.test-env	envtest/crd.go:434	read CRDs from file	{"file": "gateway.kgateway.dev_httplistenerpolicies.yaml"}
        
    ggv2setup_test.go:74: 2025-03-03T12:00:14.309-0500	DEBUG	controller-runtime.test-env	envtest/crd.go:434	read CRDs from file	{"file": "gateway.kgateway.dev_listenerpolicies.yaml"}
        
    ggv2setup_test.go:74: 2025-03-03T12:00:14.320-0500	DEBUG	controller-runtime.test-env	envtest/crd.go:434	read CRDs from file	{"file": "gateway.kgateway.dev_routepolicies.yaml"}
        
    ggv2setup_test.go:74: 2025-03-03T12:00:14.320-0500	DEBUG	controller-runtime.test-env	envtest/crd.go:316	reading CRDs from path	{"path": "testdata/istiocrds"}
        
    ggv2setup_test.go:74: 2025-03-03T12:00:14.752-0500	DEBUG	controller-runtime.test-env	envtest/crd.go:434	read CRDs from file	{"file": "crds.yaml"}
        
    ggv2setup_test.go:74: 2025-03-03T12:00:14.752-0500	DEBUG	controller-runtime.test-env	envtest/crd.go:316	reading CRDs from path	{"path": "../crds"}
        
    ggv2setup_test.go:74: 2025-03-03T12:00:15.172-0500	DEBUG	controller-runtime.test-env	envtest/crd.go:434	read CRDs from file	{"file": "gateway-crds.yaml"}
        
    ggv2setup_test.go:74: 2025-03-03T12:00:15.191-0500	DEBUG	controller-runtime.test-env	envtest/crd.go:434	read CRDs from file	{"file": "tcproute-crd.yaml"}
        
    ggv2setup_test.go:74: 2025-03-03T12:00:15.192-0500	INFO	controller-runtime.test-env	envtest/crd.go:326	there are more than one CRD definitions with the same <Group, Version, Kind, Name>	{"GVKN": {"GVK":{"Group":"apiextensions.k8s.io","Version":"v1","Kind":"CustomResourceDefinition"},"Name":"tcproutes.gateway.networking.k8s.io"}}

[github-actions]

This issue has been marked as stale because of no activity in the last 180 days. It will be closed in the next 180 days unless it is tagged "no stalebot" or other activity occurs.

[timflannagan]

Unable to reproduce locally anymore.

[timflannagan]

Whoops, wrong issue 🤦

[timflannagan]

Still reproducible locally:

$ LOG_LEVEL="debug" go test -race -v -count=1 -failfast ./internal/kgateway/setup/ -run TestScenarios/^lambda                                                                                                                                            130 ↵
testing: warning: no tests to run
PASS
ok      github.com/kgateway-dev/kgateway/v2/internal/kgateway/setup     1.231s [no tests to run]
dev :: /work/kgateway ‹main› » LOG_LEVEL="debug" go test -race -v -count=1 -failfast ./internal/kgateway/setup/ -run TestWithBindIpv4
=== RUN   TestWithBindIpv4
    setup_test.go:59: out: /home/timflannagan/.local/share/kubebuilder-envtest/k8s/1.23.5-linux-amd64
    setup_test.go:91: 2025-10-28T19:24:14.434-0400      DEBUG   controller-runtime.test-env     envtest/server.go:278   starting control plane

    setup_test.go:91: 2025-10-28T19:24:29.182-0400      DEBUG   controller-runtime.test-env     envtest/server.go:323   installing CRDs

    setup_test.go:91: 2025-10-28T19:24:29.182-0400      DEBUG   controller-runtime.test-env     envtest/crd.go:316      reading CRDs from path  {"path": "testdata/istio_crds_setup"}

    setup_test.go:91: 2025-10-28T19:24:29.617-0400      DEBUG   controller-runtime.test-env     envtest/crd.go:434      read CRDs from file     {"file": "crds.yaml"}

    setup_test.go:91: 2025-10-28T19:24:29.617-0400      DEBUG   controller-runtime.test-env     envtest/crd.go:316      reading CRDs from path  {"path": "../crds"}

    setup_test.go:91: 2025-10-28T19:24:30.200-0400      DEBUG   controller-runtime.test-env     envtest/crd.go:434      read CRDs from file     {"file": "gateway-crds.yaml"}

    setup_test.go:91: 2025-10-28T19:24:30.216-0400      DEBUG   controller-runtime.test-env     envtest/crd.go:434      read CRDs from file     {"file": "inference-crds.yaml"}

    setup_test.go:91: 2025-10-28T19:24:30.236-0400      DEBUG   controller-runtime.test-env     envtest/crd.go:434      read CRDs from file     {"file": "tcproute-crd.yaml"}

    setup_test.go:91: 2025-10-28T19:24:30.236-0400      INFO    controller-runtime.test-env     envtest/crd.go:326      there are more than one CRD definitions with the same <Group, Version, Kind, Name>      {"GVKN": {"GVK":{"Group":"apiextensions.k8s.io","Version":"v1","Kind":"CustomResourceDefinition"},"Name":"tcproutes.gateway.networking.k8s.io"}}