Skip to content

feat: add PodDisruptionBudget to kgateway helm chart #12173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
frauniki wants to merge 2 commits into from
Closed

feat: add PodDisruptionBudget to kgateway helm chart #12173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be50cd4
feat: add PodDisruptionBudget to kgateway helm chart
frauniki Sep 1, 2025
18b28d6
add values.schema.json
frauniki Sep 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions install/helm/kgateway/templates/pdb.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
{{- if .Values.podDisruptionBudget }}
Copy link

Copilot AI Sep 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The condition checks if the podDisruptionBudget key exists, but it should check if it's non-empty. An empty object {} will evaluate to true, creating a PDB with no spec fields. Use {{- if and .Values.podDisruptionBudget (or .Values.podDisruptionBudget.minAvailable .Values.podDisruptionBudget.maxUnavailable) }} instead.

Suggested change
{{- if .Values.podDisruptionBudget }}
{{- if and .Values.podDisruptionBudget (or .Values.podDisruptionBudget.minAvailable .Values.podDisruptionBudget.maxUnavailable) }}

Copilot uses AI. Check for mistakes.
Copy link
Contributor Author

@frauniki frauniki Sep 1, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, that's incorrect.
In Helm's if expression, the empty object {} evaluates to false.

apiVersion: policy/v1
kind: PodDisruptionBudget
metadata:
name: {{ include "kgateway.fullname" . }}
namespace: {{ .Release.Namespace }}
labels:
{{- include "kgateway.labels" . | nindent 4 }}
spec:
selector:
matchLabels:
{{- include "kgateway.selectorLabels" . | nindent 6 }}
{{- with .Values.podDisruptionBudget }}
{{- toYaml . | nindent 2 }}
{{- end }}
{{- end }}
Loading
Loading