Skip to content

Conversation

@npolshakova
Copy link
Contributor

@npolshakova npolshakova commented Sep 16, 2025

Leaving this open for a bit to get feedback if we want to still make this change. agentgateway is consistent with the dataplane naming, but camelcase is a common pattern with helm.

  1. rename agentGateway to agentgateway for helm values and GatewayParmeters field (user facing)
  2. rename agentGateway to agentgateway across the codebase for consistency (non user facing)
  3. rename ADP/adp (agentgateway dataplane) to Agw/agw (non user facing)

Description

Fixes #11368

Change Type

/kind breaking_change

Changelog

Rename agentGateway to agentgateway for consistency in helm values. Rename GatewayParameters agentGateway field to agentgateway.

Copilot AI review requested due to automatic review settings September 16, 2025 19:35
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR renames agentGateway to agentgateway throughout the codebase for consistency in helm values, addressing issue #11368. This is a breaking change that standardizes the naming convention to use lowercase without camelCase.

Key changes:

  • Rename Go struct types from AgentGateway to Agentgateway
  • Update helm values from agentGateway to agentgateway
  • Modify all references in test files, documentation, and configuration files

Reviewed Changes

Copilot reviewed 25 out of 26 changed files in this pull request and generated no comments.

Show a summary per file
File Description
test/kubernetes/e2e/tests/manifests/agent-gateway-integration.yaml Update helm value from agentGateway to agentgateway
test/kubernetes/e2e/features/rate_limit/local/suite.go Rename struct field and function references
test/kubernetes/e2e/features/rate_limit/global/suite.go Rename struct field references
test/kubernetes/e2e/features/backendtls/suite.go Rename struct field and update comments
test/kubernetes/e2e/features/agentgateway/transformation/testdata/gateway.yaml Update helm value reference
test/kubernetes/e2e/features/agentgateway/testdata/agentgateway-deploy.yaml Update helm value reference
pkg/deployer/values_helpers.go Update function signature and return type
pkg/deployer/values.go Rename struct type and JSON field
pkg/deployer/merge.go Update field assignment and function signature
pkg/deployer/gateway_parameters.go Update field references
pkg/deployer/deployer_test.go Update struct field reference in test
internal/kgateway/helm/kgateway/values.yaml Update helm value name
internal/kgateway/helm/kgateway/templates/gateway/proxy-deployment.yaml Update template references
internal/kgateway/helm/kgateway/templates/gateway/agent-gateway-deployment.yaml Update template references
internal/kgateway/deployer/gateway_parameters.go Update field assignment
internal/kgateway/agentgatewaysyncer/README.md Update documentation references
install/helm/kgateway/values.yaml Update helm value name
install/helm/kgateway/templates/deployment.yaml Update template condition
install/helm/kgateway-crds/templates/gateway.kgateway.dev_gatewayparameters.yaml Update CRD field name
api/v1alpha1/zz_generated.deepcopy.go Update generated code for renamed struct
api/v1alpha1/gateway_parameters_types.go Rename struct type and update method signatures
api/applyconfiguration/utils.go Update kind mapping
api/applyconfiguration/internal/internal.go Update schema references
api/applyconfiguration/api/v1alpha1/kubernetesproxyconfig.go Update field and method names
api/applyconfiguration/api/v1alpha1/agentgateway.go Rename struct and update method signatures

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Signed-off-by: npolshakova <[email protected]>

rename agentGateway to agentgateway

Signed-off-by: npolshakova <[email protected]>
Signed-off-by: npolshakova <[email protected]>
@npolshakova npolshakova force-pushed the agentGateway-to-agentgateway branch from d0c8dfa to 985c5d9 Compare September 17, 2025 18:05
Signed-off-by: npolshakova <[email protected]>
@npolshakova npolshakova added the work in progress Indicates that a PR should not merge because it is a work in progress label Sep 17, 2025
// This mirrors the envoy BackendIr pattern by pre-resolving all dependencies
// during collection building rather than at translation time.
type AgentGatewayBackendIr struct {
type AgentgatewayBackendIr struct {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use Agw for internal type names and only agentgateway for user-facing APIs and docs?

Copy link
Contributor Author

@npolshakova npolshakova Sep 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed most of the internals here: f10c346

Ones I didn't change are:

  • tests (TestAgentgatewayDeployment)
  • deployer inputs (AgentgatewayClassName seems better in line with other classes ie. WaypointGatewayClassName)
  • deployer helper functions/values (GetAgentgatewayValues, helm values on gateway.Agentgateway, etc. These are directly coming from the user inputs and translated to the deployer helm values, so keeping the sames similar makes more sense imo)

[Update] Changed ExtraAgentgatewayPlugins to ExtraAgwPlugins in: dc61cc0

Signed-off-by: npolshakova <[email protected]>
@npolshakova npolshakova requested a review from Copilot September 17, 2025 19:53
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 74 out of 75 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Signed-off-by: npolshakova <[email protected]>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 74 out of 75 changed files in this pull request and generated 6 comments.

Comments suppressed due to low confidence (2)

pkg/agentgateway/plugins/traffic_plugin.go:1

  • [nitpick] The log message should use consistent capitalization. Consider changing 'agentgateway' to 'Agentgateway' to match the type name used elsewhere in the codebase.
package plugins

pkg/agentgateway/plugins/traffic_plugin.go:1

  • [nitpick] Consider using 'agentgateway' instead of 'Agentgateway' in these user-facing log messages for consistency with the lowercase naming convention used throughout the rest of the codebase.
package plugins

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@shashankram shashankram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changelog needs to be updated to reflect the GatewayParameters API change

//
// +optional
AgentGateway *AgentGateway `json:"agentGateway,omitempty"`
Agentgateway *Agentgateway `json:"agentgateway,omitempty"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @artberger @Nadine2016 field name change


# -- Enable the integration with Agent Gateway, which lets you use kgateway to help manage agent connectivity across MCP servers, A2A agents, and REST APIs.
agentGateway:
agentgateway:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @artberger @Nadine2016 Helm value change

@npolshakova npolshakova added this pull request to the merge queue Sep 17, 2025
@shashankram shashankram removed this pull request from the merge queue due to a manual request Sep 17, 2025
@npolshakova npolshakova added this pull request to the merge queue Sep 18, 2025
github-merge-queue bot pushed a commit that referenced this pull request Sep 18, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 18, 2025
@ashleywang1 ashleywang1 added this pull request to the merge queue Sep 18, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 18, 2025
@npolshakova npolshakova added this pull request to the merge queue Sep 18, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 18, 2025
@npolshakova npolshakova added this pull request to the merge queue Sep 18, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 18, 2025
@npolshakova npolshakova added this pull request to the merge queue Sep 18, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 18, 2025
@npolshakova npolshakova added this pull request to the merge queue Sep 18, 2025
Merged via the queue into kgateway-dev:main with commit f8294a4 Sep 18, 2025
29 checks passed
@npolshakova npolshakova deleted the agentGateway-to-agentgateway branch September 18, 2025 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/breaking_change release-note work in progress Indicates that a PR should not merge because it is a work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clean up agentGateway -> agentgateway

2 participants