-
Notifications
You must be signed in to change notification settings - Fork 630
rename agentGateway to agentgateway #12293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename agentGateway to agentgateway #12293
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR renames agentGateway to agentgateway throughout the codebase for consistency in helm values, addressing issue #11368. This is a breaking change that standardizes the naming convention to use lowercase without camelCase.
Key changes:
- Rename Go struct types from
AgentGatewaytoAgentgateway - Update helm values from
agentGatewaytoagentgateway - Modify all references in test files, documentation, and configuration files
Reviewed Changes
Copilot reviewed 25 out of 26 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/kubernetes/e2e/tests/manifests/agent-gateway-integration.yaml | Update helm value from agentGateway to agentgateway |
| test/kubernetes/e2e/features/rate_limit/local/suite.go | Rename struct field and function references |
| test/kubernetes/e2e/features/rate_limit/global/suite.go | Rename struct field references |
| test/kubernetes/e2e/features/backendtls/suite.go | Rename struct field and update comments |
| test/kubernetes/e2e/features/agentgateway/transformation/testdata/gateway.yaml | Update helm value reference |
| test/kubernetes/e2e/features/agentgateway/testdata/agentgateway-deploy.yaml | Update helm value reference |
| pkg/deployer/values_helpers.go | Update function signature and return type |
| pkg/deployer/values.go | Rename struct type and JSON field |
| pkg/deployer/merge.go | Update field assignment and function signature |
| pkg/deployer/gateway_parameters.go | Update field references |
| pkg/deployer/deployer_test.go | Update struct field reference in test |
| internal/kgateway/helm/kgateway/values.yaml | Update helm value name |
| internal/kgateway/helm/kgateway/templates/gateway/proxy-deployment.yaml | Update template references |
| internal/kgateway/helm/kgateway/templates/gateway/agent-gateway-deployment.yaml | Update template references |
| internal/kgateway/deployer/gateway_parameters.go | Update field assignment |
| internal/kgateway/agentgatewaysyncer/README.md | Update documentation references |
| install/helm/kgateway/values.yaml | Update helm value name |
| install/helm/kgateway/templates/deployment.yaml | Update template condition |
| install/helm/kgateway-crds/templates/gateway.kgateway.dev_gatewayparameters.yaml | Update CRD field name |
| api/v1alpha1/zz_generated.deepcopy.go | Update generated code for renamed struct |
| api/v1alpha1/gateway_parameters_types.go | Rename struct type and update method signatures |
| api/applyconfiguration/utils.go | Update kind mapping |
| api/applyconfiguration/internal/internal.go | Update schema references |
| api/applyconfiguration/api/v1alpha1/kubernetesproxyconfig.go | Update field and method names |
| api/applyconfiguration/api/v1alpha1/agentgateway.go | Rename struct and update method signatures |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: npolshakova <[email protected]> rename agentGateway to agentgateway Signed-off-by: npolshakova <[email protected]>
Signed-off-by: npolshakova <[email protected]>
d0c8dfa to
985c5d9
Compare
Signed-off-by: npolshakova <[email protected]>
| // This mirrors the envoy BackendIr pattern by pre-resolving all dependencies | ||
| // during collection building rather than at translation time. | ||
| type AgentGatewayBackendIr struct { | ||
| type AgentgatewayBackendIr struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we use Agw for internal type names and only agentgateway for user-facing APIs and docs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed most of the internals here: f10c346
Ones I didn't change are:
- tests (TestAgentgatewayDeployment)
- deployer inputs (
AgentgatewayClassNameseems better in line with other classes ie. WaypointGatewayClassName) - deployer helper functions/values (GetAgentgatewayValues, helm values on gateway.Agentgateway, etc. These are directly coming from the user inputs and translated to the deployer helm values, so keeping the sames similar makes more sense imo)
[Update] Changed ExtraAgentgatewayPlugins to ExtraAgwPlugins in: dc61cc0
Signed-off-by: npolshakova <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 74 out of 75 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: npolshakova <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 74 out of 75 changed files in this pull request and generated 6 comments.
Comments suppressed due to low confidence (2)
pkg/agentgateway/plugins/traffic_plugin.go:1
- [nitpick] The log message should use consistent capitalization. Consider changing 'agentgateway' to 'Agentgateway' to match the type name used elsewhere in the codebase.
package plugins
pkg/agentgateway/plugins/traffic_plugin.go:1
- [nitpick] Consider using 'agentgateway' instead of 'Agentgateway' in these user-facing log messages for consistency with the lowercase naming convention used throughout the rest of the codebase.
package plugins
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
internal/kgateway/helm/kgateway/templates/gateway/agent-gateway-deployment.yaml
Show resolved
Hide resolved
internal/kgateway/helm/kgateway/templates/gateway/agent-gateway-deployment.yaml
Show resolved
Hide resolved
internal/kgateway/helm/kgateway/templates/gateway/agent-gateway-deployment.yaml
Show resolved
Hide resolved
internal/kgateway/helm/kgateway/templates/gateway/agent-gateway-deployment.yaml
Show resolved
Hide resolved
internal/kgateway/helm/kgateway/templates/gateway/agent-gateway-deployment.yaml
Show resolved
Hide resolved
shashankram
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changelog needs to be updated to reflect the GatewayParameters API change
| // | ||
| // +optional | ||
| AgentGateway *AgentGateway `json:"agentGateway,omitempty"` | ||
| Agentgateway *Agentgateway `json:"agentgateway,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @artberger @Nadine2016 field name change
|
|
||
| # -- Enable the integration with Agent Gateway, which lets you use kgateway to help manage agent connectivity across MCP servers, A2A agents, and REST APIs. | ||
| agentGateway: | ||
| agentgateway: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @artberger @Nadine2016 Helm value change
Signed-off-by: npolshakova <[email protected]>
Leaving this open for a bit to get feedback if we want to still make this change.
agentgatewayis consistent with the dataplane naming, but camelcase is a common pattern with helm.Description
Fixes #11368
Change Type
Changelog