-
Notifications
You must be signed in to change notification settings - Fork 633
deprecate envoy ai gateway and inf extension #12437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Jenny Shu <[email protected]>
Signed-off-by: Jenny Shu <[email protected]>
pkg/deployer/values.go
Outdated
| Stats *HelmStatsConfig `json:"stats,omitempty"` | ||
|
|
||
| // AI extension values | ||
| // TODO: envoy-based AI gateway is deprecated in v2.1. We can remove this in v2.2. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe rephrase "we can"? "we will"? "this will be removed"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah i thought this api was still internal, looks like it's exported now so i'll change it to a more user-facing comment
Signed-off-by: Jenny Shu <[email protected]>
| # -- Configure the integration with the Gateway API Inference Extension project, which lets you use kgateway to route to AI inference workloads like LLMs that run locally in your Kubernetes cluster. Documentation for Inference Extension can be found here: https://kgateway.dev/docs/integrations/inference-extension/ | ||
| inferenceExtension: | ||
| # -- Enable Inference Extension. | ||
| # -- Enable Inference Extension. If enabled, agentgateway.enabled should also be set to true. Enabling inference extension without agentgateway is deprecated in v2.1 and will not be supported in v2.2. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the future, is this something we can enforce with a schema definition for the values?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm maybe, would need to look into it
| backendIr := pCtx.Backend.ObjIr.(*BackendIr) | ||
| switch backend.Spec.Type { | ||
| case v1alpha1.BackendTypeAI: | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: remove newline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 can add into my next PR
Description
Add deprecation notices in API and log deprecation messages for the following:
Fixes #12372
Fixes #10878
Change Type
/kind deprecation
Changelog
Additional Notes