agentgateway: report nacks via events #12770
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joe McGuire <[email protected]> Signed-off-by: Joe McGuire <[email protected]>
Signed-off-by: Joe McGuire <[email protected]> Signed-off-by: Joe McGuire <[email protected]>
Signed-off-by: Joe McGuire <[email protected]> Signed-off-by: Joe McGuire <[email protected]>
Signed-off-by: Joe McGuire <[email protected]> Signed-off-by: Joe McGuire <[email protected]>
Signed-off-by: Joe McGuire <[email protected]> Signed-off-by: Joe McGuire <[email protected]>
…an limit the perf damage we're doing here Signed-off-by: Joe McGuire <[email protected]> Signed-off-by: Joe McGuire <[email protected]>
Signed-off-by: Joe McGuire <[email protected]> Signed-off-by: Joe McGuire <[email protected]>
Signed-off-by: Joe McGuire <[email protected]> Signed-off-by: Joe McGuire <[email protected]>
Signed-off-by: Joe McGuire <[email protected]> Signed-off-by: Joe McGuire <[email protected]>
Signed-off-by: Joe McGuire <[email protected]> Signed-off-by: Joe McGuire <[email protected]>
Signed-off-by: Joe McGuire <[email protected]> Signed-off-by: Joe McGuire <[email protected]>
Signed-off-by: Joe McGuire <[email protected]> Signed-off-by: Joe McGuire <[email protected]>
Signed-off-by: Joe McGuire <[email protected]>
Signed-off-by: Joe McGuire <[email protected]>
Signed-off-by: Joe McGuire <[email protected]>
github-actions
bot
added
kind/feature
Signed-off-by: Joe McGuire <[email protected]>
Signed-off-by: Joe McGuire <[email protected]>
npolshakova
reviewed
Oct 29, 2025
npolshakova
reviewed
Oct 29, 2025
npolshakova
reviewed
Oct 29, 2025
npolshakova
reviewed
Oct 29, 2025
npolshakova
reviewed
Oct 29, 2025
Signed-off-by: Joe McGuire <[email protected]>
…emaining nacks Signed-off-by: Joe McGuire <[email protected]>
jmcguire98
force-pushed
the
report-agw-nacks-on-gateways
branch
from
d1de508 to
d93746e
Compare
Signed-off-by: Joe McGuire <[email protected]>
Signed-off-by: Joe McGuire <[email protected]>
Signed-off-by: Joe McGuire <[email protected]>
Signed-off-by: Joe McGuire <[email protected]>
howardjohn
reviewed
Nov 4, 2025
jmcguire98
changed the title
… writing) Signed-off-by: Joe McGuire <[email protected]>
Signed-off-by: Joe McGuire <[email protected]>
Signed-off-by: Joe McGuire <[email protected]>
…nymore Signed-off-by: Joe McGuire <[email protected]>
Signed-off-by: Joe McGuire <[email protected]> Signed-off-by: Joe McGuire <[email protected]>
Signed-off-by: jmcguire98 <[email protected]>
Signed-off-by: Joe McGuire <[email protected]>
…ents Signed-off-by: Joe McGuire <[email protected]>
Signed-off-by: Joe McGuire <[email protected]>
Signed-off-by: Joe McGuire <[email protected]>
npolshakova
reviewed
Nov 7, 2025
| corev1.EventSource{Component: wellknown.DefaultAgwControllerName}, | ||
| ) | ||
| eventBroadcaster.StartRecordingToSink(&typedcorev1.EventSinkImpl{ | ||
| Interface: client.Kube().CoreV1().Events(""), |
Contributor
There was a problem hiding this comment.
Do we want the events to be cluster-wide? (vs. only being in the gw ns)
Contributor
Author
There was a problem hiding this comment.
When we're initializing the eventbroadcaster we have to give it perms to publish events cluster wide, but when we're actually publishing the events we have to publish them in the same ns as their involvedObject (k8s apiserver requirement)
npolshakova
reviewed
Nov 7, 2025
| UID: deployUID, | ||
| } | ||
|
|
||
| p.eventRecorder.Eventf(gatewayRef, corev1.EventTypeWarning, ReasonNack, event.ErrorMsg) |
Contributor
There was a problem hiding this comment.
Does the ErrorMsg have the type url of the resource in it?
Contributor
Author
There was a problem hiding this comment.
the ErrorMsg is pretty verbose:
and assuming agentgateway is telling us which resource name it nacked it should be easy to track down.
npolshakova
approved these changes
Nov 7, 2025
Contributor
Author
|
/merge |
howardjohn
reviewed
Nov 7, 2025
|
|
||
| if nackHandler != nil { | ||
| gateway := kgwxds.AgentgatewayID(con.node) | ||
| // Collect resource names from the request only (subscribe/unsubscribe/initial versions) |
Contributor
There was a problem hiding this comment.
on error, agentgateway will not send any sub/unsub/initial version in the request. so this should always be empty afaik
Contributor
Author
There was a problem hiding this comment.
Yeah, that's true.
i think you may have an old version loaded. I ended up getting rid of all this logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We want to be able to more easily surface to end users cases where configuration they have provided has been translated into config that was rejected (NACKed) by the gateway they were sending it to. In the past this most frequently happened when a user created a policy with illegal CEL which was nacked at the gateway (subsequently we added CEL validation before translating).
To achieve this I have added a NACK publisher that publishes k8s events when an instance of a NACK occurs.
Change Type
/kind new_feature
Changelog
Additional Notes
fixes #12671