Fix mcp backend auth #12897
Merged
Fix mcp backend auth #12897
+161
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: npolshakova <[email protected]>
Signed-off-by: npolshakova <[email protected]>
gateway-bot
added
kind/fix
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in MCP authorization policy parsing where the function was incorrectly reading from the Traffic authorization config instead of the Backend MCP authorization config.
- Corrected
translateBackendMCPAuthorizationto read frompolicy.Spec.Backend.MCP.Authorizationinstead ofpolicy.Spec.Traffic.Authorization - Added nil safety checks for backend, MCP, and authorization fields
- Added comprehensive test coverage for the fix including edge cases
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/agentgateway/plugins/backend_policies.go | Fixed authorization parsing to correctly access backend MCP authorization config and added nil safety checks |
| pkg/agentgateway/plugins/backend_policies_test.go | Added comprehensive test coverage for MCP authorization translation including nil checks, allow/deny actions, and verification that traffic authorization is properly ignored |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
timflannagan
approved these changes
Nov 17, 2025
ymesika
approved these changes
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes MCP Auth policies parsing to look at the AgentgatewayPolicy backend config.
Change Type
Changelog