trafficpolicy clean up: remove ai policy #12901
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gateway-bot
added
do-not-merge/description-invalid
do-not-merge/kind-invalid
Member
|
Very much in favor of this. Just shoot me a ping once this is ready for review. |
gateway-bot
added
kind/breaking_change
release-note
and removed
do-not-merge/kind-invalid
puertomontt
force-pushed
the
tp-cleanup
branch
from
86c8e43 to
598f2cf
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes AI policy functionality from the TrafficPolicy resource as part of a breaking change. The envoy-based AI gateway is being deprecated and removed.
Key changes:
- Removed AI policy field and related configuration from TrafficPolicy CRD
- Cleaned up AI-specific filter names and processing logic from traffic policy plugin
- Removed AI extproc filter disabling logic from backend plugin
- Renamed
Templatetype toInjaTemplatefor clarity
Reviewed Changes
Copilot reviewed 45 out of 45 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/kgateway/wellknown/constants.go | Removed AI-specific filter name constants |
| internal/kgateway/extensions2/plugins/trafficpolicy/traffic_policy_plugin.go | Removed AI policy processing logic and IR handling |
| internal/kgateway/extensions2/plugins/trafficpolicy/merge.go | Removed AI policy merge function |
| internal/kgateway/extensions2/plugins/trafficpolicy/constructor.go | Removed AI policy IR construction |
| internal/kgateway/extensions2/plugins/trafficpolicy/ai_policy.go | Deleted entire AI policy implementation file |
| internal/kgateway/extensions2/plugins/trafficpolicy/ai_policy_test.go | Deleted entire AI policy test file |
| internal/kgateway/extensions2/plugins/backend/plugin.go | Removed AI extproc filter disabling logic |
| install/helm/kgateway-crds/templates/gateway.kgateway.dev_trafficpolicies.yaml | Removed AI field from CRD schema and updated validation rules |
| api/v1alpha1/traffic_policy_types.go | Removed AI field from TrafficPolicySpec and renamed Template to InjaTemplate |
| api/v1alpha1/zz_generated.deepcopy.go | Updated generated deepcopy code to reflect type rename |
| Multiple test output YAML files | Removed AI extproc filter config entries from expected outputs |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
internal/kgateway/setup/testdata/standard/auto-host-plus-host-rewrite-out.yaml
Show resolved
Hide resolved
puertomontt
force-pushed
the
tp-cleanup
branch
from
598f2cf to
7a1ba38
Compare
howardjohn
approved these changes
Nov 17, 2025
Signed-off-by: omar <[email protected]>
puertomontt
force-pushed
the
tp-cleanup
branch
from
7a1ba38 to
719deed
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove deprecated AI policy from TrafficPolicy.
Change Type
/kind breaking_change
Changelog
Additional Notes