add global disable option for JWT #12945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gateway-bot
added
do-not-merge/description-invalid
do-not-merge/kind-invalid
gateway-bot
added
kind/feature
puertomontt
force-pushed
the
jwt-disable
branch
from
4671115 to
19a7b1f
Compare
Contributor
There was a problem hiding this comment.
Copilot reviewed 20 out of 20 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
internal/kgateway/extensions2/plugins/trafficpolicy/traffic_policy_plugin.go:1
- The TODO comment on line 424 should be removed as global JWT disable filter support has been implemented in this PR.
package trafficpolicy
internal/kgateway/extensions2/plugins/trafficpolicy/traffic_policy_plugin.go:1
- The commented-out line on line 440 should be removed since it's now uncommented on line 441 as part of this PR's implementation.
package trafficpolicy
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
puertomontt
commented
Nov 21, 2025
internal/kgateway/extensions2/plugins/trafficpolicy/gateway_extension.go
Show resolved
Hide resolved
jenshu
reviewed
Nov 21, 2025
puertomontt
force-pushed
the
jwt-disable
branch
from
19a7b1f to
351ed09
Compare
yuval-k
reviewed
Nov 21, 2025
internal/kgateway/extensions2/plugins/trafficpolicy/traffic_policy_plugin.go
Show resolved
Hide resolved
yuval-k
reviewed
Nov 21, 2025
Signed-off-by: omar <[email protected]>
puertomontt
force-pushed
the
jwt-disable
branch
from
351ed09 to
147092d
Compare
lgadban
reviewed
Nov 25, 2025
Contributor
lgadban
left a comment
lgadban
left a comment
There was a problem hiding this comment.
mostly LGTM! just a few minor comments and questions
internal/kgateway/extensions2/plugins/trafficpolicy/gateway_extension.go
Show resolved
Hide resolved
internal/kgateway/translator/gateway/testutils/outputs/jwt/rbac.yaml
Outdated
Show resolved
Hide resolved
internal/kgateway/extensions2/plugins/trafficpolicy/gateway_extension.go
Show resolved
Hide resolved
Signed-off-by: omar <[email protected]>
Signed-off-by: omar <[email protected]>
Signed-off-by: omar <[email protected]>
lgadban
approved these changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add global disable option for JWT policy, implemented with composite filter in same manner as ext proc.
Change Type
/kind new_feature
Changelog
Additional Notes