cleanup: Uses MergePointers, not MergeComparable, for pointers #12978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While *string (and, without loss of generality, *bool) is technically comparable in Go (so it compiles), the semantics are wrong: 1. For *string, the zero value check src == t is just checking src == nil -- same as MergePointers 2. It does not compare the actual string values; it compares addresses 3. Two different *string pointers to the empty string wouldn't be equal Signed-off-by: David L. Chandler <[email protected]>
gateway-bot
added
kind/cleanup
davidjumani
approved these changes
Nov 25, 2025
Contributor
Author
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While *string (and, without loss of generality, *bool) is technically comparable in Go (so MergeComparable compiles), the semantics are wrong:
This is a cleanup only; there's no bug to fix.
Change Type
/kind cleanup
Changelog
Additional Notes