-
Notifications
You must be signed in to change notification settings - Fork 634
feat: initial proxy protocol support #12979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 5 commits
883cb9b
56bedfa
e0a8750
89094b4
bc49a08
2016187
89b8467
4d87b0c
4bcab2d
7f3b73e
32f0d89
5db7afc
81f62b7
d6d545c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,67 @@ | ||||||||||
| package v1alpha1 | ||||||||||
|
|
||||||||||
| import ( | ||||||||||
| metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||||||||||
| gwv1 "sigs.k8s.io/gateway-api/apis/v1" | ||||||||||
| ) | ||||||||||
|
|
||||||||||
| // +kubebuilder:rbac:groups=gateway.kgateway.dev,resources=listenerpolicies,verbs=get;list;watch | ||||||||||
| // +kubebuilder:rbac:groups=gateway.kgateway.dev,resources=listenerpolicies/status,verbs=get;update;patch | ||||||||||
|
|
||||||||||
| // +kubebuilder:printcolumn:name="Accepted",type=string,JSONPath=".status.ancestors[*].conditions[?(@.type=='Accepted')].status",description="Listener policy acceptance status" | ||||||||||
| // +kubebuilder:printcolumn:name="Attached",type=string,JSONPath=".status.ancestors[*].conditions[?(@.type=='Attached')].status",description="Listener policy attachment status" | ||||||||||
|
|
||||||||||
| // +genclient | ||||||||||
| // +kubebuilder:object:root=true | ||||||||||
| // +kubebuilder:metadata:labels={app=kgateway,app.kubernetes.io/name=kgateway} | ||||||||||
| // +kubebuilder:resource:categories=kgateway | ||||||||||
| // +kubebuilder:subresource:status | ||||||||||
| // +kubebuilder:metadata:labels="gateway.networking.k8s.io/policy=Direct" | ||||||||||
| // ListenerPolicy is used for configuring Envoy listener-level settings that apply to all protocol types (HTTP, HTTPS, TCP, TLS). | ||||||||||
| // This includes features such as PROXY protocol support. | ||||||||||
| // These policies can targetRef Gateway objects. | ||||||||||
|
||||||||||
| // These policies can targetRef Gateway objects. | |
| // These policies can only target `Gateway` objects. |
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment is incorrect right? Only Gateway attachment and no sectionName support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right - the comment is not right - i think i fixed the CEL validation but missed that one
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| // TargetRefs specifies the target resources by reference to attach the policy to. | |
| // Supports Gateway and XListenerSet resources. Use sectionName to target specific listeners by port. | |
| // TargetRefs specifies the target resources by reference to attach the policy to. | |
| // Only supports `Gateway` resources. |
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| // TargetSelectors specifies the target selectors to select resources to attach the policy to. | |
| // TargetSelectors specifies the target selectors to select `Gateway` resources to attach the policy to. |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you think it's worth including this in the comments?
we'll need to constantly be updating it etc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i can remove