feat: add stat matcher config to gatewayparameters #12985
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuval Kohavi <[email protected]>
gateway-bot
added
kind/feature
yuval-k
changed the title
puertomontt
reviewed
Nov 25, 2025
puertomontt
approved these changes
Nov 25, 2025
Signed-off-by: Yuval Kohavi <[email protected]>
Co-authored-by: Omar Hammami <[email protected]> Signed-off-by: Yuval Kohavi <[email protected]>
Signed-off-by: Yuval Kohavi <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for configuring Envoy stats matcher (inclusion/exclusion lists) via GatewayParameters to help limit stats emission in high-scale scenarios. The implementation adds a new Matcher field to StatsConfig that allows users to specify either an inclusion or exclusion list of string matchers to control which Envoy stats are emitted.
Key changes:
- Added
StatsMatcherand reusedStringMatchertypes to the API with CRD validation ensuring mutual exclusivity - Implemented conversion from API types to Helm values and rendering in Envoy bootstrap configuration
- Added comprehensive test coverage for both inclusion and exclusion list scenarios
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| api/v1alpha1/gateway_parameters_types.go | Added StatsMatcher struct and Matcher field to StatsConfig with getter methods |
| api/v1alpha1/zz_generated.deepcopy.go | Auto-generated deepcopy methods for new StatsMatcher type |
| install/helm/kgateway-crds/templates/gateway.kgateway.dev_gatewayparameters.yaml | Added CRD schema for matcher with mutual exclusion validation and string matcher definitions |
| pkg/deployer/values.go | Added HelmStatsMatcher and HelmStringMatcher structs for Helm values |
| pkg/deployer/values_helpers.go | Implemented conversion logic from API StatsMatcher to Helm values |
| pkg/deployer/merge.go | Added matcher field to stats config merge logic |
| internal/kgateway/helm/envoy/templates/configmap.yaml | Added Envoy bootstrap stats_config rendering with inclusion/exclusion list support |
| pkg/deployer/deployer_test.go | Added integration tests verifying inclusion and exclusion list rendering in Envoy bootstrap |
| examples/example-gatewayparameters-stats-matcher.yaml | Added example demonstrating stats matcher configuration usage |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
install/helm/kgateway-crds/templates/gateway.kgateway.dev_gatewayparameters.yaml
Show resolved
Hide resolved
Signed-off-by: Yuval Kohavi <[email protected]>
Signed-off-by: Yuval Kohavi <[email protected]>
Signed-off-by: Yuval Kohavi <[email protected]>
Signed-off-by: Yuval Kohavi <[email protected]>
Signed-off-by: Yuval Kohavi <[email protected]>
timflannagan
approved these changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #11284
Description
In high scale scenarios it's helpful to limit the emount of stats envoy emits. This change adds config toggles for tune the stats emission.
Change Type
Changelog