Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 16, 2025

Description

The importas linter currently enforces an alias for sigs.k8s.io/gateway-api/apis/v1alpha3, but this package version is not imported or used anywhere in the codebase.

Motivation: The unused import alias configuration clutters the linter config and enforces rules for a package that isn't used in the project.

What changed: Removed the gwv1a3 import alias enforcement from .golangci.yaml.

Related issues: Addresses the issue about removing unused v1alpha3 Gateway API package from linter config.

The project uses Gateway API versions v1, v1alpha2, and v1beta1 only. The v1alpha3 references found in test data are for Istio's networking.istio.io/v1alpha3 API, not Gateway API.

Change Type

/kind cleanup

Changelog

NONE

Additional Notes

The linter configuration has been tested and works correctly after this change. No code changes were needed, only the linter configuration update.

Original prompt

This section details on the original issue you should resolve

<issue_title>Remove sigs.k8s.io/gateway-api/apis/v1alpha3 from .golangci.yaml</issue_title>
<issue_description>The importas linter currently enforces the sigs.k8s.io/gateway-api/apis/v1alpha3 package which isn't used throughout the codebase. My 2c: either remove this and/or update depguard to prevent this package form being imported until we have a need for that group version again.</issue_description>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI changed the title [WIP] Remove sigs.k8s.io/gateway-api/apis/v1alpha3 from .golangci.yaml Remove unused v1alpha3 Gateway API import alias from linter config Dec 16, 2025
Copilot AI requested a review from timflannagan December 16, 2025 06:33
@timflannagan timflannagan marked this pull request as ready for review December 16, 2025 06:36
Copilot AI review requested due to automatic review settings December 16, 2025 06:36
@gateway-bot gateway-bot added do-not-merge/description-invalid do-not-merge/kind-invalid Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/release-note-invalid Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 16, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes an unused import alias configuration from the golangci-lint settings. The importas linter was enforcing the alias gwv1a3 for the Gateway API package sigs.k8s.io/gateway-api/apis/v1alpha3, but this package version is not imported anywhere in the codebase.

Key Changes:

  • Removed gwv1a3 import alias enforcement from .golangci.yaml

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@timflannagan
Copy link
Member

@copilot Take a look at the AGENTS.md guidance for PR desciptions.

Copy link
Contributor Author

Copilot AI commented Dec 16, 2025

@copilot Take a look at the AGENTS.md guidance for PR desciptions.

Updated the PR description to follow the AGENTS.md template format with proper Description, Change Type (/kind cleanup), and Changelog sections. The formatted description is now in PR_DESCRIPTION.md (commit 7228755).

@timflannagan
Copy link
Member

@copilot No need for a changelog entry here.

Copy link
Contributor Author

Copilot AI commented Dec 16, 2025

@copilot No need for a changelog entry here.

Removed the changelog entry and replaced it with "NONE" (commit c7e8669).

@gateway-bot gateway-bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none labels Dec 16, 2025
@gateway-bot gateway-bot removed do-not-merge/description-invalid do-not-merge/kind-invalid Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/release-note-invalid Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 16, 2025
@timflannagan
Copy link
Member

@copilot Remove the PR description file. I meant edit the PR description itself and include that information (vs. creating an explicit file).

auto-merge was automatically disabled January 6, 2026 03:42

Head branch was pushed to by a user without write access

Copy link
Contributor Author

Copilot AI commented Jan 6, 2026

@copilot Remove the PR description file. I meant edit the PR description itself and include that information (vs. creating an explicit file).

Removed the PR_DESCRIPTION.md file (commit b1c42e5). The PR description has been updated directly instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove sigs.k8s.io/gateway-api/apis/v1alpha3 from .golangci.yaml

4 participants