-
Notifications
You must be signed in to change notification settings - Fork 635
Remove unused v1alpha3 Gateway API import alias from linter config #13151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: timflannagan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR removes an unused import alias configuration from the golangci-lint settings. The importas linter was enforcing the alias gwv1a3 for the Gateway API package sigs.k8s.io/gateway-api/apis/v1alpha3, but this package version is not imported anywhere in the codebase.
Key Changes:
- Removed
gwv1a3import alias enforcement from.golangci.yaml
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@copilot Take a look at the AGENTS.md guidance for PR desciptions. |
Co-authored-by: timflannagan <[email protected]>
|
@copilot No need for a changelog entry here. |
Co-authored-by: timflannagan <[email protected]>
|
@copilot Remove the PR description file. I meant edit the PR description itself and include that information (vs. creating an explicit file). |
Co-authored-by: timflannagan <[email protected]>
Head branch was pushed to by a user without write access
Description
The importas linter currently enforces an alias for
sigs.k8s.io/gateway-api/apis/v1alpha3, but this package version is not imported or used anywhere in the codebase.Motivation: The unused import alias configuration clutters the linter config and enforces rules for a package that isn't used in the project.
What changed: Removed the
gwv1a3import alias enforcement from.golangci.yaml.Related issues: Addresses the issue about removing unused v1alpha3 Gateway API package from linter config.
The project uses Gateway API versions
v1,v1alpha2, andv1beta1only. The v1alpha3 references found in test data are for Istio'snetworking.istio.io/v1alpha3API, not Gateway API.Change Type
/kind cleanup
Changelog
Additional Notes
The linter configuration has been tested and works correctly after this change. No code changes were needed, only the linter configuration update.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.