Fix ai prompt guard enums #13177
Merged
Fix ai prompt guard enums #13177
+37
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gateway-bot
added
kind/fix
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the AI prompt guard enum values to align with the project's naming conventions for enums. The constants MASK and REJECT are updated to use Pascal case (Mask and Reject), and corresponding enum validation is added to enforce these values in the Kubernetes API.
- Updated
Actionenum constants fromMASK/REJECTtoMask/Rejectin the Go API - Added kubebuilder validation annotation to enforce the new enum values
- Added explicit enum constraints to CRD templates for AgentgatewayPolicy and AgentgatewayBackend
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
api/v1alpha1/agentgateway/ai_policy.go |
Updated Action enum constant values from uppercase to Pascal case and added kubebuilder validation annotation |
install/helm/agentgateway-crds/templates/agentgateway.dev_agentgatewaypolicies.yaml |
Added enum validation constraints for Action field in request and response prompt guard configurations |
install/helm/agentgateway-crds/templates/agentgateway.dev_agentgatewaybackends.yaml |
Added enum validation constraints for Action field across multiple prompt guard configuration locations in the backend CRD |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: npolshakova <[email protected]> fix tests Signed-off-by: npolshakova <[email protected]>
npolshakova
force-pushed
the
fix-ai-policy-enums
branch
from
8a55c23 to
dd45221
Compare
lgadban
approved these changes
Dec 18, 2025
Contributor
There was a problem hiding this comment.
this is the only test that uses the enum names?
timflannagan
approved these changes
Dec 18, 2025
howardjohn
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #13173
Change Type
Changelog