Update err message while referring to incorrect port on service #13178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yaten <[email protected]>
gateway-bot
added
kind/fix
npolshakova
reviewed
Dec 26, 2025
npolshakova
reviewed
Dec 26, 2025
Signed-off-by: Yaten <[email protected]>
Author
|
Hi @npolshakova , apologies for the delay on this, I've made the suggested changes, with all the unit tests passing, kindly check :) |
Author
|
Hi @npolshakova , did you get time to review this 👀 ? |
yuval-k
reviewed
Jan 8, 2026
pkg/krtcollections/policy.go
Outdated
| } | ||
| } | ||
| if found { | ||
| return nil, &BackendPortNotFoundError{Port: port, BackendName: n.Name, Namespace: n.Namespace} |
Contributor
There was a problem hiding this comment.
you also need to account for alias logic below (see the call to getBackendFromAlias) - do the error logic if getBackendFromAlias fails
Author
There was a problem hiding this comment.
Isn't the error logic already there - https://github.com/kgateway-dev/kgateway/pull/13178/changes#diff-9760745752b7c20a2c9236474a1a5c82973b1399cbd0bd814e67a1ace8997c2dR270-R271 ?
Correct me if I'm wrong here, I didn't fully understand this comment!
Signed-off-by: Yaten <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #11998
Currently, if the user adds an incorrect port in the service, it results in an err like this:
But, since, the service exists, the err should be something like this:
Change Type
/kind bug_fix
Changelog
Additional Notes