Skip to content

Conversation

@andy-fong
Copy link
Contributor

@andy-fong andy-fong commented Dec 31, 2025

Description

Update: The code changes for prepping multi-arch support are separated into a separate PR #13242 as fixing all the tests turns out to be a lot of changes. So, this PR will be a follow up of #13242 to switch the default and fixes all the test, so in case we have to revert the default, it's in a single commit.

  • switched to use rustformation by default
  • account for architecture when building the rustformation module because for v2.2 release, we plan to keep envoy-gloo for x86 in case users need to switch back to classic transformation but will support arm build by using vanilla upstream envoy.
  • envoy-gloo has patched the rust sdk to support add_header but it's not available yet on envoy 1.36.x. After we upgrade to v1.37 envoy (to be released), we can search for the REMOVE-ENVOY-1.37 comment and clean up the arch specific code.

Change Type

/kind cleanup

Changelog

Switched to rustformation by default

Additional Notes

@gateway-bot gateway-bot added do-not-merge/description-invalid do-not-merge/kind-invalid Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/release-note-invalid Indicates that a PR should not merge because it's missing one of the release note labels. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note and removed do-not-merge/description-invalid do-not-merge/kind-invalid Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/release-note-invalid Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 31, 2025
Signed-off-by: Andy Fong <[email protected]>
Signed-off-by: Andy Fong <[email protected]>
@andy-fong andy-fong changed the title Switch to rustformation by default switched to rustformation by default Dec 31, 2025
Signed-off-by: Andy Fong <[email protected]>
… doesn't work the same as the inja templete validation from classic transformation yet

Signed-off-by: Andy Fong <[email protected]>
Signed-off-by: Andy Fong <[email protected]>
Signed-off-by: Andy Fong <[email protected]>
@andy-fong andy-fong added the work in progress Indicates that a PR should not merge because it is a work in progress label Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note work in progress Indicates that a PR should not merge because it is a work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants