Add AgentgatewayPolicy frontend tracing support #13226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npolshakova
added
the
work in progress
gateway-bot
added
kind/feature
Signed-off-by: npolshakova <[email protected]>
Signed-off-by: npolshakova <[email protected]>
Signed-off-by: npolshakova <[email protected]>
Signed-off-by: npolshakova <[email protected]>
Signed-off-by: npolshakova <[email protected]>
Signed-off-by: npolshakova <[email protected]>
npolshakova
force-pushed
the
xds-tracing-api-changes
branch
from
3cb7014 to
cd5bd31
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds frontend tracing support for AgentgatewayPolicy, enabling OpenTelemetry tracing configuration for incoming gateway traffic. The implementation includes new API types for resource attributes, translation logic to convert policies to agent gateway format, and updated CRD schemas with validation rules.
Key changes:
- Added
Resourcesfield to the Tracing spec for configuring OTEL resource attributes - Implemented translation logic in
translateFrontendTracingto convert tracing policies to agent gateway API format - Removed the CRD validation that blocked tracing configuration (
x-kubernetes-validationsrule)
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
api/v1alpha1/agentgateway/agentgateway_policy_types.go |
Added ResourceAdd type and Resources field to Tracing struct; removed "not implemented" comments |
api/v1alpha1/agentgateway/zz_generated.deepcopy.go |
Auto-generated deepcopy methods for new ResourceAdd type and updated Tracing deepcopy to handle Resources slice |
install/helm/agentgateway-crds/templates/agentgateway.dev_agentgatewaypolicies.yaml |
Added resources field schema to tracing spec; removed validation blocking tracing implementation; fixed grammar in attributes description |
pkg/agentgateway/plugins/frontend_policies.go |
Implemented translateFrontendTracing function to convert tracing policy to agent gateway format, including backend reference, attributes, resources, and sampling configuration |
pkg/agentgateway/plugins/testdata/frontendpolicy/full.yaml |
Added complete tracing test case with expected output showing proper translation of all tracing fields |
test/e2e/features/tracing/testdata/setup.yaml |
Removed GatewayParameters, Gateway, and HTTPRoute definitions (likely moved to separate e2e PR mentioned in description) |
go.mod |
Added temporary local replace directive for agentgateway dependency |
go.sum |
Removed agentgateway v0.11.0 checksums due to local replacement |
hack/utils/oss_compliance/osa_provided.md |
Updated agentgateway dependency version from v0.11.0 to "latest" |
Comments suppressed due to low confidence (1)
go.mod:672
- This is a temporary local replacement for the agentgateway dependency that should be removed before merging. The PR description mentions that an agentgateway release is required before this can be merged. Ensure this replace directive is removed and the dependency is updated to the proper version when that release is available.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: npolshakova <[email protected]>
Signed-off-by: npolshakova <[email protected]>
npolshakova
removed
the
work in progress
Signed-off-by: Lawrence Gadban <[email protected]>
howardjohn
approved these changes
Jan 7, 2026
|
|
||
| var randomSampling *string | ||
| if tracing.RandomSampling != nil { | ||
| randomSampling = ptr.Of(string(*tracing.RandomSampling)) |
|
|
||
| provider, err := buildBackendRef(ctx, tracing.BackendRef, policy.Namespace) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("failed to translate tracing backend ref: %v", err) |
Contributor
There was a problem hiding this comment.
Not needed in this PR but this is one of the broader things we discussed recently -- we should be sending tracing config with an invalid backend probably. But we can fix it more holistically and not in this PR
Contributor
There was a problem hiding this comment.
we can use #13231 as a starting point for this convo
lgadban
approved these changes
Jan 7, 2026
lgadban
approved these changes
Jan 7, 2026
lgadban
reviewed
Jan 7, 2026
| } | ||
|
|
||
| func translateFrontendTracing(policy *agentgateway.AgentgatewayPolicy, name string, target *api.PolicyTarget) []AgwPolicy { | ||
| func translateFrontendTracing(ctx PolicyCtx, policy *agentgateway.AgentgatewayPolicy, name string, target *api.PolicyTarget) ([]AgwPolicy, error) { |
Contributor
There was a problem hiding this comment.
looks like the convention is to name the PolicyCtx variable/param as ctx.
as a new reader this is a bit confusing given how overloaded ctx is with Context
Contributor
|
@howardjohn can you reapprove? I had to fix one of the e2e tests and for some reason it thinks your approval came before that commit... |
howardjohn
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Requires agentgateway release before this can be merged.
Description
Fixes: #11818
Change Type
Changelog
Additional Notes
e2e tests are introduced in a separate follow up PR: #13076