Change field names in TrafficPolicy to be more consistent before release #13254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Pritchard <[email protected]>
gateway-bot
added
do-not-merge/description-invalid
kind/cleanup
davidjumani
approved these changes
Jan 9, 2026
npolshakova
approved these changes
Jan 9, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR renames fields in the TrafficPolicy API for improved consistency before the release. The changes rename jwt to jwtAuth and apiKeyAuthentication to apiKeyAuth in the TrafficPolicySpec, along with corresponding type renames from JWTAuthentication to JWTAuth and APIKeyAuthentication to APIKeyAuth.
Key changes:
- Updated API type definitions and generated deepcopy code for renamed types
- Modified CRD templates to reflect new field names
- Updated plugin implementations to use renamed fields
- Updated test data files and translator test inputs within the PR scope
Reviewed changes
Copilot reviewed 28 out of 28 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| api/v1alpha1/kgateway/traffic_policy_types.go | Updated field names from JWT to JWTAuth and APIKeyAuthentication to APIKeyAuth |
| api/v1alpha1/kgateway/jwt_types.go | Renamed type from JWTAuthentication to JWTAuth |
| api/v1alpha1/kgateway/zz_generated.deepcopy.go | Updated generated deepcopy methods for renamed types |
| pkg/kgateway/extensions2/plugins/trafficpolicy/jwt.go | Updated field access from in.Spec.JWT to in.Spec.JWTAuth |
| pkg/kgateway/extensions2/plugins/trafficpolicy/api_key_auth.go | Updated field access from spec.APIKeyAuthentication to spec.APIKeyAuth |
| install/helm/kgateway-crds/templates/gateway.kgateway.dev_trafficpolicies.yaml | Updated CRD schema with new field names and descriptions |
| test/e2e/features/jwt/testdata/jwt.yaml | Updated TrafficPolicy spec from jwt: to jwtAuth: |
| test/e2e/features/jwt/testdata/jwt-rbac.yaml | Updated TrafficPolicy spec from jwt: to jwtAuth: |
| test/e2e/features/apikeyauth/testdata/*.yaml | Updated all API key auth test files from apiKeyAuthentication: to apiKeyAuth: |
| pkg/kgateway/translator/gateway/testutils/inputs/traffic-policy/*.yaml | Updated all traffic policy test input files with new field names |
| pkg/kgateway/translator/gateway/testutils/inputs/jwt/*.yaml | Updated JWT test input files with new field names |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gateway-bot
added
kind/breaking_change
release-note
and removed
kind/cleanup
lgadban
approved these changes
Jan 9, 2026
jenshu
approved these changes
Jan 9, 2026
Signed-off-by: Joshua Pritchard <[email protected]>
auto-merge was automatically disabled
January 9, 2026 19:54
Head branch was pushed to by a user without write access
Signed-off-by: Joshua Pritchard <[email protected]>
davidjumani
approved these changes
Jan 9, 2026
lgadban
approved these changes
Jan 9, 2026
Contributor
Author
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change field names in TrafficPolicy to be more consistent before release #13254
Change Type
/kind breaking_change
Changelog
Additional Notes
resolves #13069