Overlays (strategic merge patch) for GatewayParameters #13266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is analogous to AgentgatewayParameters' KubernetesResourceOverlay (which is in a different group `agentgateway.dev` and cannot be reused for that reason). Overlays are a powerful and readable mechanism for removing, adding, and changing the details of the Kubernetes Deployments, Services, ServiceAccounts, PodDisruptionBudgets, and HorizontalPodAutoscalers deployed. One could argue that many of the existing GatewayParameters fields would not have existed if overlays had been present from the start, but we maintain compatibility and you are free to use either mechanism. Some things that were previously impossible are now possible, but only via overlays. GatewayParameters can be present on both a GatewayClass and a Gateway, and just as was the case before overlays, params on a Gateway are merged into params from the GatewayClass and the Gateway params take precedence. Signed-off-by: David L. Chandler <[email protected]>
gateway-bot
added
kind/feature
Signed-off-by: David L. Chandler <[email protected]>
Signed-off-by: David L. Chandler <[email protected]>
Signed-off-by: David L. Chandler <[email protected]>
Signed-off-by: David L. Chandler <[email protected]>
Signed-off-by: David L. Chandler <[email protected]>
Signed-off-by: David L. Chandler <[email protected]>
Signed-off-by: David L. Chandler <[email protected]>
Signed-off-by: David L. Chandler <[email protected]>
…e worked around via overlays Signed-off-by: David L. Chandler <[email protected]>
Signed-off-by: David L. Chandler <[email protected]>
Signed-off-by: David L. Chandler <[email protected]>
Signed-off-by: David L. Chandler <[email protected]>
Signed-off-by: David L. Chandler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is analogous to AgentgatewayParameters' KubernetesResourceOverlay (which is in a different group
agentgateway.devand cannot be reused for that reason).Overlays are a powerful and readable mechanism for removing, adding, and changing the details of the Kubernetes Deployments, Services, ServiceAccounts, PodDisruptionBudgets, and HorizontalPodAutoscalers deployed.
One could argue that many of the existing GatewayParameters fields would not have existed if overlays had been present from the start, but we maintain compatibility and you are free to use either mechanism. Some things that were previously impossible are now possible, but only via overlays.
GatewayParameters can be present on both a GatewayClass and a Gateway, and just as was the case before overlays, params on a Gateway are merged into params from the GatewayClass and the Gateway params take precedence.
Resolves #12263
Resolves #13025
Ameliorates #13265
Change Type
/kind feature
Changelog
Additional Notes