Migrate to Docker v2

[24aysh]

Description

Migrated from deprecated dockers + docker_manifests to the new dockers_v2 configuration
Fixes the cause of revert #13257
Fixes issue #13195
Fixes envoy image shrinkage issue

Change Type

/kind cleanup
/kind deprecation

Changelog

Migrated from deprecated `dockers` + `docker_manifests` to `dockers_v2` in GoReleaser configuration

[24aysh]

@chandler-solo envoy had some path issues so it was not copying correct, it was using full path like platform/arch..
linux/arm64/envoyinit-linux-* /usr/local/bin/envoyinit
I fixed that in d209388
using TARGETPLATFORM, it should work now, i have also verified locally

[24aysh]

something is off, i am working on it

[24aysh]

something is off, i am working on it

but i think it should have been worked earlier too if that's the real issue

[chandler-solo]

In a perfect world, local development would use goreleaser to build docker images so that we only had one way to build them and had more confidence in CI (which does not use the goreleaser-built images in the e2e tests today and instead uses some logic surrounding BUILDX_BUILD ?= docker buildx build -q in the Makefile). We do run goreleaser on each PR in --snapshot mode today, but we don't validate and verify the images.

[24aysh]

In a perfect world, local development would use goreleaser to build docker images so that we only had one way to build them and had more confidence in CI (which does not use the goreleaser-built images in the e2e tests today and instead uses some logic surrounding BUILDX_BUILD ?= docker buildx build -q in the Makefile). We do run goreleaser on each PR in --snapshot mode today, but we don't validate and verify the images.

working on it, i had some work so i left it there, will update it soon

[24aysh]

ok so if i use change the wildcard as i did in 555c95d, the ci checks fail, but the images built locally are same. And if fix those ci checks, then images are malformed. I need to find a trade off between them
@chandler-solo

[24aysh]

ok so if i use change the wildcard as i did in 555c95d, the ci checks fail, but the images built locally are same. And if fix those ci checks, then images are malformed. I need to find a trade off between them @chandler-solo

and i think i got the reason why i got the same images and later they were different when you were comparing. I compared when the tests were failing, they were same, and after i changed the wildcard to let the ci checks pass, the images broke, and you got different images
I suppose all images were malformed then, not only envoy.
@chandler-solo

I'll fix this asap

[chandler-solo]

@24aysh, the very best outcome would be to delete the Makefile docker image building code and replace it with goreleaser release --snapshot --clean. It might actually be faster than the Makefile technique, but I'd sacrifice a little speed to have a single way to build images, making it more likely my local testing will fix bugs in production. Feel up to it?

[24aysh]

@24aysh, the very best outcome would be to delete the Makefile docker image building code and replace it with goreleaser release --snapshot --clean. It might actually be faster than the Makefile technique, but I'd sacrifice a little speed to have a single way to build images, making it more likely my local testing will fix bugs in production. Feel up to it?

yeah, let me try it