feat: Add linter and fix EOF newlines (fixes #12133) #13285
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation:
This PR introduces a check to ensure all files in the repository end with a trailing newline character. This ensures compliance with POSIX standards and prevents "No newline at end of file" warnings in git diffs, keeping the codebase clean and consistent.
What changed:
hack/check-eof-newline.shscript to verify and optionally fix files missing EOF newlines.make check-eof-newlineandmake fix-eof-newlinetargets to the Makefile..yaml,.md, and.gofiles).Related issues:
Fixes #12133
Change Type
/kind cleanup
Changelog
Additional Notes
I used the new
make fix-eof-newlinetarget to apply these changes automatically. The script usesgit ls-filesto respect.gitignoreand skips binary files.