Updating to v7 causes C# language mismatch

[Piedone]

This is very strange, but this is what happens:

With Scrutor v6.1.0 everything is fine. After updating to v7.0.0 we get a build error from this line from a project using it:

error CS8652: The feature 'params collections' is currently in Preview and unsupported. To use Preview features, use the 'preview' language version.

See the build here.

Note the following:

• The JObject.FromObject() call is just using System.Text.Json.Nodes.JObject. That method doesn't use params and I don't understand how the error is related to its signature:

public static JsonObject? FromObject(object? obj, JsonSerializerOptions? options = null)

• This is part of a larger solution, this one (other projects in it use Scrutor too).
• All projects in the solution target .NET 8 and use C# 12.

I suspect this related to #265 and .NET 10 and doesn't happen if the project targets .NET 10 (what it soon will have).

[khellang]

Hi @Piedone! I'm not sure I follow. How does the version of Scrutor affect the language features used in your source code? And what do you think I can/should do about it? 😅 The .NET 10 bump was a simple additional target framework. If you don't target .NET 10, you'd probably end up with the old .NET 8 target.

[Piedone]

I'm not sure :). But with Scrutor v6.1.0, everything is fine, with v7.0.0 I get the above error, with nothing else changing.

Maybe the issue is that package references leak through, and .NET 8 projects shouldn't use e.g. v10 of Microsoft.Extensions.DependencyInjection.Abstractions. In Orchard Core, we've overcome this with conditional package references like the ones here: https://github.com/OrchardCMS/OrchardCore/blob/0b7b4a335e861d50a80f1280fab81f26b0d9d9fb/Directory.Packages.props#L88