Skip to content
This repository was archived by the owner on Jan 29, 2023. It is now read-only.

Add newer Adafruit boards#5

Merged
khoih-prog merged 1 commit into
khoih-prog:masterfrom
brentru:add-newer-adafruit-boards
Jun 16, 2022
Merged

Add newer Adafruit boards#5
khoih-prog merged 1 commit into
khoih-prog:masterfrom
brentru:add-newer-adafruit-boards

Conversation

@brentru

@brentru brentru commented Jun 16, 2022

Copy link
Copy Markdown
Contributor

Hi, we're looking into using this library with Adafruit WipperSnapper since its non-blocking.

Added #define's for some of the more recent Adafruit boards within arduino-esp32 BSP.
Bump semver, please release when merged.

@khoih-prog khoih-prog merged commit cc1b6a5 into khoih-prog:master Jun 16, 2022
@khoih-prog

Copy link
Copy Markdown
Owner

@brentru

Merged and released shortly. Looking forward to receiving more PRs from you as there are too many new Adafruit boards I can't keep up updating.

Thanks.

@brentru brentru deleted the add-newer-adafruit-boards branch June 16, 2022 19:52
@brentru

brentru commented Jun 16, 2022

Copy link
Copy Markdown
Contributor Author

@khoih-prog More boards during this time isn't a bad thing! Is there a way we can collapse this #define at all? or any of these?

Could you explain the #define for ESP32 a bit? I haven't seen this macro before - does it target ESP32 (non-c3/s2/..) boards such as the Feather HUZZAH32?

@khoih-prog

Copy link
Copy Markdown
Owner

Do you mean this

#elif defined(ESP32)
#define USING_ESP32_TIMERINTERRUPT true

If so, it's trying to catch any ESP32 board not identified in previous defines, assuming it's a normal ESP32 (non C3, S2, S3, etc). Better than compile error.

@brentru

brentru commented Jun 16, 2022

Copy link
Copy Markdown
Contributor Author

Yes, I did mean L42. Good way of catching the non-Sx/-Cx boards!

@khoih-prog

Copy link
Copy Markdown
Owner

Hi @brentru

The new ESP32_ISR_Servo release v1.3.1 has just been published.

Your contribution is noted in Contributions and Thanks

Best Regards,


Releases v1.3.1

  1. Add support to new Adafruit boards such as QTPY_ESP32S2, FEATHER_ESP32S3_NOPSRAM and QTPY_ESP32S3_NOPSRAM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants