-
Notifications
You must be signed in to change notification settings - Fork 7
docker support #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
timdinh
wants to merge
2
commits into
kiapanahi:main
Choose a base branch
from
timdinh:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
docker support #24
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| **/bin/ | ||
| **/obj/ | ||
| **/.vs/ | ||
| **/.idea/ | ||
| **/.git/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| FROM mcr.microsoft.com/dotnet/aspnet:9.0 AS base | ||
| WORKDIR /app | ||
| EXPOSE 80 | ||
|
|
||
| ENV DOTNET_CLI_TELEMETRY_OPTOUT=true \ | ||
| DOTNET_SKIP_FIRST_TIME_EXPERIENCE=true \ | ||
| ASPNETCORE_URLS=http://+:80 \ | ||
| ASPNETCORE_ENVIRONMENT=Production | ||
|
|
||
| FROM mcr.microsoft.com/dotnet/sdk:9.0 AS build | ||
| ARG BUILD_CONFIGURATION=Release | ||
|
|
||
| WORKDIR "/src" | ||
| COPY . . | ||
|
|
||
| RUN dotnet restore "/src/src/Aspire.ResourceService.Standalone.Server/Aspire.ResourceService.Standalone.Server.csproj" | ||
|
|
||
| RUN dotnet build "/src/src/Aspire.ResourceService.Standalone.Server/Aspire.ResourceService.Standalone.Server.csproj" -f net9.0 -c $BUILD_CONFIGURATION -o /app/build | ||
|
|
||
| FROM build AS publish | ||
| ARG BUILD_CONFIGURATION=Release | ||
|
|
||
| RUN dotnet publish "/src/src/Aspire.ResourceService.Standalone.Server/Aspire.ResourceService.Standalone.Server.csproj" -f net9.0 -c $BUILD_CONFIGURATION -o /app/publish | ||
|
|
||
| FROM base AS final | ||
| WORKDIR /app | ||
| COPY --from=publish /app/publish . | ||
| ENTRYPOINT ["dotnet", "Aspire.ResourceService.Standalone.Server.dll"] | ||
timdinh marked this conversation as resolved.
Show resolved
Hide resolved
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| #!/bin/sh | ||
|
|
||
| # Exit immediately if a command exits with a non-zero status. | ||
| set -e | ||
| # Ensure that the exit status of a pipeline is the status of the last command to exit with a non-zero status. | ||
| set -o pipefail | ||
|
|
||
| current_date=$(date +%Y%m%d) | ||
|
|
||
| docker pull mcr.microsoft.com/dotnet/sdk:9.0 | ||
| docker pull mcr.microsoft.com/dotnet/aspnet:9.0 | ||
|
|
||
| docker buildx build --platform linux/arm64,linux/amd64 -f Dockerfile \ | ||
| -t aspire-resource-server:latest \ | ||
| -t aspire-resource-server:$current_date \ | ||
| -t timdinh/aspire-resource-server:latest \ | ||
| -t timdinh/aspire-resource-server:$current_date \ | ||
timdinh marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| .. | ||
|
|
||
| docker push timdinh/aspire-resource-server:latest | ||
| docker push timdinh/aspire-resource-server:$current_date | ||
timdinh marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I created this docker-compose file, the main reason was to create a sample environment from which the resource server could inspect and collect information. I don't see how adding the resource server to the compose file would help. Would you care to shine some light on why this is helpful?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea is to show how the resource server can be configured with docker compose as an example. User can then point their service to the docker container instance of resource server or the executable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In that case, I'd appreciate it if you could move this sample compose file into a separate
samplesdirectory, preferably with aREADME.mdfile describing what the sample directory contains and why it's there.