MBL-2679: Use stripe-ios-spm module instead of stripe-ios #2568
+10
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reduces our downloaded package sizes by several GB.
amy-at-kickstarter
changed the title
amy-at-kickstarter
force-pushed
the
feat/adyer/use-stripe-spm-package
branch
from
74c2c94 to
5e7ba5d
Compare
amy-at-kickstarter
changed the title
| "revision" : "8a35266fab2e0ba116dec7d651ae69a0ca7bc7b7", | ||
| "version" : "23.27.2" | ||
| "revision" : "653fc8cfc40b33740401f9bd9faa8588f9a53e5f", | ||
| "version" : "23.32.0" |
There was a problem hiding this comment.
We download up to the next major version. Switching repos bumped this version, I surmise. I poked through their most recent release notes and (as expected) this is just a bunch of bug fixes and minor upgrades; nothing that should affect us.
amy-at-kickstarter
requested review from
a team,
stevestreza-ksr and
ifosli
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Use the
stripe-ios-spmmirror repo, instead ofstripe-ios.🤔 Why
stripe-iosis our largest downloaded package, clocking in at several gigabytes. Their mirror repostripe-ios-spmhas no git history, making it substantially smaller.One of the biggest time consumers on CircleCI is downloading our SPM packages and then caching them in a workspace. By reducing our SPM package sizes, we shave entire minutes off our build times on CircleCI:
I saw speed-ups of around ~5-6 minutes for the entire build pipeline by making this change.
👀 See
I triple-checked that this is a valid and supported SPM repo: