Conversation
cs278
force-pushed
the
fix-refl
branch
3 times, most recently
from
2cfd2c3 to
761fed4
Compare
cs278
requested review from
a team,
Jamesking56 and
sjdawson
and removed request for
a team
cs278
commented
Dec 23, 2021
cs278
force-pushed
the
fix-refl
branch
2 times, most recently
from
5449a90 to
986c8bc
Compare
By handle I mean ignore.
In PHP 8 these methods do not have return types whilst their matching functions do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was looking at adding PHP 8.1 support but I was getting big mismatches between argument names in error messages, so I figured best clean this up first.